fix(memory): harden memory followups#1796
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
📝 WalkthroughWalkthroughPR1794 hardens the memory subsystem end-to-end: ChangesMemory Hardening (Core, DB, UI, i18n)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 19
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/renderer/src/i18n/da-DK/settings.json`:
- Around line 2293-2297: Replace the English language values for the memory
management keys in the Danish locale file with proper Danish translations. The
keys searchFailed, deletePermanent, deleteConfirmTitle, deleteConfirmBody, and
the advanced hint keys at lines 2429-2436 currently contain English text but
should have Danish translations to maintain consistent language in the Danish
UI. Translate each of these string values from English to Danish to provide a
complete localized experience for Danish users.
In `@src/renderer/src/i18n/de-DE/settings.json`:
- Around line 224-228: The new memory-related keys searchFailed,
deletePermanent, deleteConfirmTitle, and deleteConfirmBody in the
de-DE/settings.json localization file are still in English and need to be
translated to German. Translate each of these values to their German equivalents
to ensure German users see consistent language throughout the interface. Also
apply the same translations to the additional range mentioned at lines 2420-2427
for any similar untranslated keys.
In `@src/renderer/src/i18n/es-ES/settings.json`:
- Around line 224-228: The Spanish translation file es-ES/settings.json contains
four untranslated keys that are still in English: "searchFailed",
"deletePermanent", "deleteConfirmTitle", and "deleteConfirmBody". Translate each
of these key values from English to Spanish to maintain consistency with the
rest of the Spanish UI localization. Ensure the translations are accurate and
follow the same style and tone as the existing Spanish translations in the file,
and also apply the same translation fixes to the other affected ranges mentioned
(lines 2420-2427).
In `@src/renderer/src/i18n/fa-IR/settings.json`:
- Around line 2293-2297: The fa-IR language file contains English text values
for newly added memory management keys (searchFailed, deletePermanent,
deleteConfirmTitle, deleteConfirmBody) and similar keys in the 2429-2436 range,
which should be translated to Persian. Locate each of these English string
values in the fa-IR settings.json file and replace them with their appropriate
Persian translations to maintain UI consistency and provide proper localization
for Persian-speaking users.
In `@src/renderer/src/i18n/fr-FR/settings.json`:
- Around line 2293-2297: The French localization file fr-FR/settings.json
contains new memory-related string keys that are still in English instead of
French. Translate the values for the keys searchFailed, deletePermanent,
deleteConfirmTitle, and deleteConfirmBody from English to French. Additionally,
translate the corresponding memory configuration strings in the range referenced
as applying to lines 2429-2436. Keep all key names unchanged, only translate the
string values to maintain locale consistency for the French language file.
In `@src/renderer/src/i18n/he-IL/settings.json`:
- Around line 2294-2297: The memory-related string keys searchFailed,
deletePermanent, deleteConfirmTitle, and deleteConfirmBody in the Hebrew locale
file are still in English, causing mixed-language UI for Hebrew users. Translate
these four string values to Hebrew by replacing the English text with
appropriate Hebrew translations. Apply the same Hebrew translations to the
duplicate keys mentioned in the additional range at lines 2430-2436 to ensure
consistent localization throughout the memory search/delete dialogs and advanced
settings.
In `@src/renderer/src/i18n/id-ID/settings.json`:
- Around line 225-228: The new strings added to the Indonesian locale file
(searchFailed, deletePermanent, deleteConfirmTitle, deleteConfirmBody) and the
additional entries mentioned at lines 2421-2427 are currently left in English.
Translate all these string values to Indonesian to maintain consistent
localization and avoid mixing languages in the user interface. Update each
English value with its proper Indonesian translation while keeping the key names
unchanged.
In `@src/renderer/src/i18n/it-IT/settings.json`:
- Around line 225-228: The Italian translation file it-IT/settings.json contains
English text for the memory-related strings searchFailed, deletePermanent,
deleteConfirmTitle, and deleteConfirmBody. Replace these English values with
their proper Italian translations to ensure the Italian UI displays Italian text
instead of English fallbacks. Also check and translate any similar untranslated
English strings in the file around lines 2421-2427 that are mentioned as having
the same issue.
In `@src/renderer/src/i18n/ja-JP/settings.json`:
- Around line 2294-2297: The ja-JP/settings.json file contains English strings
for newly added keys (searchFailed, deletePermanent, deleteConfirmTitle,
deleteConfirmBody and additional entries mentioned in the comment) that should
be localized to Japanese. Translate all these English strings to their
appropriate Japanese equivalents to ensure the Japanese localization is complete
and consistent. Review all the mentioned sections to identify and replace each
English string with its Japanese translation.
In `@src/renderer/src/i18n/ko-KR/settings.json`:
- Around line 2294-2297: The Korean translation file (ko-KR/settings.json)
contains English text for the newly added keys searchFailed, deletePermanent,
deleteConfirmTitle, and deleteConfirmBody (around lines 2294-2297), which
creates inconsistent mixed-language content on Korean settings screens.
Translate these English string values into proper Korean equivalents. Also apply
the same Korean translations to the related keys mentioned at lines 2430-2436
that have the same localization issue.
In `@src/renderer/src/i18n/ms-MY/settings.json`:
- Around line 225-228: The strings "searchFailed", "deletePermanent",
"deleteConfirmTitle", and "deleteConfirmBody" in the ms-MY locale file are
currently in English and need to be translated to Malay to provide consistent
language in the Malay UI. Replace the English values with their Malay
translations for all four of these keys. Additionally, ensure the same
localization is applied to the corresponding strings mentioned at lines
2421-2427 as indicated in the comment.
In `@src/renderer/src/i18n/pl-PL/settings.json`:
- Around line 225-228: The Polish locale file (pl-PL/settings.json) contains
English text for new memory-related keys instead of Polish translations.
Translate the values for the keys searchFailed, deletePermanent,
deleteConfirmTitle, and deleteConfirmBody from English to Polish. Additionally,
check lines 2421-2427 mentioned in the comment for any other English text that
needs Polish translation to ensure the entire Polish locale file is complete and
consistent.
In `@src/renderer/src/i18n/pt-BR/settings.json`:
- Around line 2293-2297: The pt-BR settings file contains newly added keys with
English values instead of Brazilian Portuguese translations. Locate and
translate the following keys to Portuguese: searchFailed, deletePermanent,
deleteConfirmTitle, deleteConfirmBody, and the additional keys mentioned in the
range 2429-2436. Replace each English string value with an appropriate Brazilian
Portuguese translation to ensure consistent localization for Portuguese-speaking
users.
In `@src/renderer/src/i18n/ru-RU/settings.json`:
- Around line 2293-2297: The ru-RU localization file contains new keys with
English values instead of Russian translations, creating mixed-language UI. For
the keys searchFailed, deletePermanent, deleteConfirmTitle, and
deleteConfirmBody in the settings.json file, replace the English text values
with proper Russian translations. Also check the additional ranges mentioned
(lines 2429-2436) for similar untranslated English strings and provide Russian
translations for those keys as well.
In `@src/renderer/src/i18n/tr-TR/settings.json`:
- Around line 225-228: The newly added memory-related strings in the Turkish
locale file (tr-TR) are still in English instead of being translated. Translate
the following keys to Turkish: "searchFailed", "deletePermanent",
"deleteConfirmTitle", "deleteConfirmBody", and the advanced memory hint strings
(which are also referenced in lines 2421-2427). Replace the English values with
appropriate Turkish translations for each of these keys to ensure the UI
displays consistently in Turkish for users of this locale.
In `@src/renderer/src/i18n/vi-VN/settings.json`:
- Around line 225-228: The new memory-manager and advanced-config translation
keys including searchFailed, deletePermanent, deleteConfirmTitle,
deleteConfirmBody (lines 225-228) and additional keys at lines 2421-2427 are
still in English rather than Vietnamese, causing inconsistent language
presentation. Translate all these English string values to their Vietnamese
equivalents to maintain consistent language throughout the vi-VN settings file.
Ensure the translations accurately convey the original meaning while using
appropriate Vietnamese phrasing.
In `@src/renderer/src/i18n/zh-CN/settings.json`:
- Around line 222-225: The Chinese locale file settings.json contains English
strings for newly added memory feature keys instead of Chinese translations.
Locate and replace the English values for the keys searchFailed,
deletePermanent, deleteConfirmTitle, and deleteConfirmBody (appearing at lines
222-225 and lines 2421-2427) with their appropriate Chinese translations to
ensure consistent localization in the zh-CN locale file.
In `@src/renderer/src/i18n/zh-HK/settings.json`:
- Around line 2294-2297: The zh-HK locale file contains English text for the
keys searchFailed, deletePermanent, deleteConfirmTitle, and deleteConfirmBody
instead of Hong Kong Chinese translations. Replace all English string values for
these keys with appropriate Traditional Chinese translations suitable for Hong
Kong locale. Ensure all four keys are translated consistently with the rest of
the Hong Kong Chinese locale file to maintain a consistent user experience.
In `@src/renderer/src/i18n/zh-TW/settings.json`:
- Around line 2294-2297: The memory-related strings in the zh-TW locale file
(searchFailed, deletePermanent, deleteConfirmTitle, and deleteConfirmBody around
line 2294, and additional strings around lines 2430-2436) are still in English
instead of being translated to Traditional Chinese. Translate these English
values to their appropriate Traditional Chinese equivalents to maintain
consistent localization throughout the file and prevent mixed-language text from
appearing in the user interface for Taiwanese users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a417a972-2951-4824-ab96-278a373e733c
📒 Files selected for processing (34)
docs/issues/pr1794-memory-hardening/plan.mddocs/issues/pr1794-memory-hardening/spec.mddocs/issues/pr1794-memory-hardening/tasks.mdsrc/main/presenter/agentRuntimePresenter/index.tssrc/main/presenter/databaseSecurityPresenter/index.tssrc/main/presenter/memoryPresenter/extraction.tssrc/main/presenter/memoryPresenter/index.tssrc/main/presenter/sqlitePresenter/index.tssrc/main/presenter/sqlitePresenter/tables/agentMemory.tssrc/main/presenter/sqlitePresenter/tables/deepchatTapeSearchProjection.tssrc/renderer/settings/components/MemoryConfigPanel.vuesrc/renderer/settings/components/MemoryManagerPanel.vuesrc/renderer/settings/components/MemorySettings.vuesrc/renderer/src/i18n/da-DK/settings.jsonsrc/renderer/src/i18n/de-DE/settings.jsonsrc/renderer/src/i18n/en-US/settings.jsonsrc/renderer/src/i18n/es-ES/settings.jsonsrc/renderer/src/i18n/fa-IR/settings.jsonsrc/renderer/src/i18n/fr-FR/settings.jsonsrc/renderer/src/i18n/he-IL/settings.jsonsrc/renderer/src/i18n/id-ID/settings.jsonsrc/renderer/src/i18n/it-IT/settings.jsonsrc/renderer/src/i18n/ja-JP/settings.jsonsrc/renderer/src/i18n/ko-KR/settings.jsonsrc/renderer/src/i18n/ms-MY/settings.jsonsrc/renderer/src/i18n/pl-PL/settings.jsonsrc/renderer/src/i18n/pt-BR/settings.jsonsrc/renderer/src/i18n/ru-RU/settings.jsonsrc/renderer/src/i18n/tr-TR/settings.jsonsrc/renderer/src/i18n/vi-VN/settings.jsonsrc/renderer/src/i18n/zh-CN/settings.jsonsrc/renderer/src/i18n/zh-HK/settings.jsonsrc/renderer/src/i18n/zh-TW/settings.jsontest/main/presenter/memoryExtraction.test.ts
💤 Files with no reviewable changes (1)
- src/main/presenter/agentRuntimePresenter/index.ts
Collaborator
|
LGTM |
yyhhyyyyyy
added a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm run formatpassedpnpm run i18npassedpnpm run lintpassedpnpm run typecheckpassedpnpm testwas started but stopped per request aftermemoryPresenter.test.tssurfaced failures/timeoutsNote: local environment used Node v26.0.0 while package.json expects >=24.14.1 <25, so pnpm emitted engine warnings.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation