Skip to content

Add missing MAC settings profile ID path fields #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halimi merged 4 commits into from
Jul 1, 2026
Merged

Add missing MAC settings profile ID path fields #7952

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42eb443
ns: Add missing MAC settings profile ID path fields
halimi Jun 25, 2026
6885565
dev: Update CHANGELOG
halimi Jun 25, 2026
621ed76
ns: Add factory reset test for ABP devices with MAC settings profile
halimi Jun 29, 2026
a65fb3e
ns: Add flow test for OTAA device with MAC settings profile
halimi Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ For details about compatibility between different releases, see the **Commitment

### Fixed

- Applying the MAC settings profile values to the device's MAC state during the join procedure (OTAA) or factory reset (ABP).

### Security

## [3.36.1] - 2026-06-24
Expand Down
1 change: 1 addition & 0 deletions pkg/networkserver/grpc_deviceregistry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,6 +1533,7 @@ func (ns *NetworkServer) ResetFactoryDefaults(ctx context.Context, req *ttnpb.Re
"lorawan_phy_version",
"lorawan_version",
"mac_settings",
"mac_settings_profile_ids",
"multicast",
"session.dev_addr",
"session.keys",
Expand Down
4 changes: 3 additions & 1 deletion pkg/networkserver/grpc_gsns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,11 +840,13 @@ func appendRecentUplink(
}

var handleDataUplinkGetPaths = [...]string{
"battery_percentage",
"frequency_plan_id",
"last_dev_status_received_at",
"lorawan_phy_version",
"lorawan_version",
"mac_settings",
"mac_settings_profile_ids",
"mac_state",
"multicast",
"pending_mac_state",
Expand All @@ -853,7 +855,6 @@ var handleDataUplinkGetPaths = [...]string{
"supports_class_b",
"supports_class_c",
"supports_join",
"battery_percentage",
}

// mergeMetadata merges the metadata collected for up.
Expand Down Expand Up @@ -1264,6 +1265,7 @@ func (ns *NetworkServer) handleJoinRequest(ctx context.Context, up *ttnpb.Uplink
"lorawan_phy_version",
"lorawan_version",
"mac_settings",
"mac_settings_profile_ids",
"session.dev_addr",
"supports_class_b",
"supports_class_c",
Expand Down
Loading