Fix implicitly deleted operator= for variadic_results#1630
Open
VaderDev wants to merge 1 commit intoThePhD:developfrom
Open
Fix implicitly deleted operator= for variadic_results#1630VaderDev wants to merge 1 commit intoThePhD:developfrom
VaderDev wants to merge 1 commit intoThePhD:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR enables move and copy assignment of
sol::variadic_results. Currently the move and copy assignment is implicitly deleted becausesol::basic_variadic_resultsdeclares a move constructor with= default. Such declaration for copy and move constructor is not necessary, removing them would re-enable move and copy assignment.Alternative implementation: with C++20 support move and copy assignment could be
= default-ed too.Alternative implementation: move and copy assignment could be could be user provided (with static_cast to base).
Example of usage of assignments which are implicitly deleted:
GCC 14.2 output: