Skip to content

chore(SSRTest): Fix flaky test - Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test#1513

Merged
Marcosld merged 5 commits intomasterfrom
WEB-2417
Mar 11, 2026
Merged

chore(SSRTest): Fix flaky test - Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test#1513
Marcosld merged 5 commits intomasterfrom
WEB-2417

Conversation

@Marcosld
Copy link
Copy Markdown
Contributor

@Marcosld Marcosld commented Mar 10, 2026 •
edited
Loading

@Marcosld Marcosld self-assigned this Mar 10, 2026
@Marcosld Marcosld requested a review from atabel March 10, 2026 08:55
@Marcosld Marcosld changed the title WEB-2417: Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test internal(Chore): Fix flaky test - Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test Mar 10, 2026
@neo-sagittal neo-sagittal self-requested a review March 10, 2026 08:57
@neo-sagittal
Copy link
Copy Markdown

neo-sagittal commented Mar 10, 2026

I'm reviewing this, it might take a few minutes, I'll add comments and update here when it's done.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026 •
edited
Loading

Size stats

master this branch diff
Total JS 16.1 MB 16.1 MB 0 B
JS without icons 2 MB 2 MB 0 B
Lib overhead 92.2 kB 92.2 kB 0 B
Lib overhead (gzip) 19.9 kB 19.9 kB 0 B

@neo-sagittal
Copy link
Copy Markdown

neo-sagittal commented Mar 10, 2026

I've checked the PR against the requirements in the ticket WEB-2417:

✅ Fix the flaky SSR image test to make it stable
✅ Address timing issues where the image sometimes loads on time and sometimes doesn't

neo-sagittal
neo-sagittal approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown

@neo-sagittal neo-sagittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember you can easily customize how your team reviews code!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-hw96pftgh-flows-projects-65bb050e.vercel.app

Built with commit 688c578.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@Marcosld Marcosld changed the title internal(Chore): Fix flaky test - Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test chore(SSRTest): Fix flaky test - Use waitUntil networkidle0 so puppeteer waits for image to load in ssr test Mar 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026 •
edited
Loading

Screenshot tests report

✔️ All passing

@Marcosld Marcosld added this pull request to the merge queue Mar 11, 2026
Merged via the queue into master with commit 7a05aab Mar 11, 2026
11 checks passed
@Marcosld Marcosld deleted the WEB-2417 branch March 11, 2026 09:06
@tuentisre
Copy link
Copy Markdown
Collaborator

tuentisre commented Mar 13, 2026

🎉 This PR is included in version 16.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atabel atabel atabel approved these changes

@neo-sagittal neo-sagittal neo-sagittal approved these changes

Assignees

@Marcosld Marcosld

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marcosld @neo-sagittal @tuentisre @atabel