Skip to content

feat(Menu, IconButton): Use danger backgrounds with danger types #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yceballost merged 8 commits into from
Aug 14, 2026
Merged

feat(Menu, IconButton): Use danger backgrounds with danger types #1505

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
113cfbe
change iconButton and menu danger backgrounds
yceballost Feb 24, 2026
b1a02a9
prettier
yceballost Feb 24, 2026
f187490
rollback change in alternative variant
yceballost Feb 24, 2026
00b8845
Update icon-button.css.ts
yceballost Feb 27, 2026
31ee560
Merge branch 'master' into iceballos-backgroundHover-menu-iconButton-…
yceballost Mar 25, 2026
e417e1f
Merge branch 'master' into iceballos-backgroundHover-menu-iconButton-…
yceballost Apr 29, 2026
be12ff8
Merge branch 'master' into iceballos-backgroundHover-menu-iconButton-…
Marcosld Jul 21, 2026
5746272
Merge branch 'master' into iceballos-backgroundHover-menu-iconButton-…
yceballost Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/icon-button.css.ts
View file
Open in desktop
Comment thread
aweell marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -280,24 +280,24 @@ export const iconButtonTokens = styleVariants({
'danger-transparent-default': {
vars: {
[background]: 'transparent',
[backgroundHover]: skinVars.colors.backgroundContainerHover,
[backgroundActive]: skinVars.colors.backgroundContainerPressed,
[backgroundHover]: skinVars.colors.buttonLinkDangerBackgroundPressed,
[backgroundActive]: skinVars.colors.buttonLinkDangerBackgroundPressed,
Comment thread
atabel marked this conversation as resolved.
[iconColor]: skinVars.colors.error,
},
},
'danger-transparent-brand': {
vars: {
[background]: skinVars.colors.buttonLinkDangerBackgroundBrand,
[backgroundHover]: skinVars.colors.backgroundContainerHover,
[backgroundActive]: skinVars.colors.backgroundContainerPressed,
[backgroundHover]: skinVars.colors.buttonLinkDangerBackgroundPressed,
[backgroundActive]: skinVars.colors.buttonLinkDangerBackgroundPressed,
[iconColor]: skinVars.colors.error,
},
},
'danger-transparent-negative': {
vars: {
[background]: skinVars.colors.buttonLinkDangerBackgroundBrand,
[backgroundHover]: skinVars.colors.backgroundContainerHover,
[backgroundActive]: skinVars.colors.backgroundContainerPressed,
[backgroundHover]: skinVars.colors.buttonLinkDangerBackgroundPressed,
[backgroundActive]: skinVars.colors.buttonLinkDangerBackgroundPressed,
[iconColor]: skinVars.colors.error,
},
},
Expand Down
14 changes: 14 additions & 0 deletions src/menu.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,20 @@ export const menuItemHovered = style({
},
});

export const menuItemHoveredDestructive = style({
transition: 'background-color 0.1s ease-in-out',
backgroundColor: skinVars.colors.buttonLinkDangerBackgroundPressed,
':active': {
backgroundColor: skinVars.colors.buttonLinkDangerBackgroundPressed,
},
'@media': {
[mq.touchableOnly]: {
backgroundColor: 'transparent',
transition: 'none',
},
},
});

export const menuItemEnabled = style({
'@media': {
[mq.touchableOnly]: {
Expand Down
5 changes: 4 additions & 1 deletion src/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ export const MenuItem = ({
className={classnames(styles.menuItem, {
[styles.menuItemEnabled]: !disabled,
[styles.menuItemDisabled]: disabled,
[styles.menuItemHovered]: !disabled && itemIndex !== null && focusedItem === itemIndex,
[styles.menuItemHovered]:
!disabled && !destructive && itemIndex !== null && focusedItem === itemIndex,
[styles.menuItemHoveredDestructive]:
!disabled && destructive && itemIndex !== null && focusedItem === itemIndex,
})}
onMouseMove={() => setFocusedItem(disabled ? null : itemIndex)}
onMouseLeave={() => setFocusedItem(null)}
Expand Down
Loading