feat: <CR> respects mode-specific keymaps#14
Open
WayneKent wants to merge 1 commit into
Open
Conversation
Pass <CR> through handleInsertKeybind in insert mode. Route normal mode <CR> through processKeystroke for keybind resolution. Fallback to submit when normal mode <CR> has no mapping. Document input_submit interaction and add Chinese translation.
WayneKent
force-pushed
the
feat/cr-mode-aware
branch
from
b44b573 to
3614e02
Compare
Author
|
Hi, just a friendly bump — appreciate your time when you get a chance to review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
<CR>(Enter) respect mode-specific keymaps fromtui.json, just like any other keybinding.Changes
<CR>now goes throughhandleInsertKeybind, supporting"submit"and"normal"mappings. Unmapped<CR>falls through to the host (inserts newline or submits, depending oninput_submit).<CR>routes throughprocessKeystrokefor proper keybind resolution — supports"submit","insert", and arbitrary Vim key sequences. Falls back to submit when unmapped.README.zh.md,docs/configuration.zh.md).