Skip to content

ci(detect-agent): remove the detect-agent workflow#10781

Merged
TkDodo merged 1 commit into
mainfrom
ci/remove-detect-agent-workflow
May 25, 2026
Merged

ci(detect-agent): remove the detect-agent workflow#10781
TkDodo merged 1 commit into
mainfrom
ci/remove-detect-agent-workflow

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented May 25, 2026

🎯 Changes

Remove detect-agent.yml for the same fork-PR limitation.

The workflow's main value is identifying AI agents in external (fork) PRs, but with pull_request the GITHUB_TOKEN is downgraded to read-only on forks, so it can't apply labels there — exactly where it would be most useful. The official bombshell-dev/automation docs recommend pull_request_target (and note the workflow only reads PR metadata without checking out fork code), but we're keeping a hard line against pull_request_target to avoid carving out exceptions to that policy.

Removed file:

  • .github/workflows/detect-agent.yml

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Removed internal GitHub Actions workflow configuration. No user-facing changes.

@sukvvon sukvvon requested a review from a team as a code owner May 25, 2026 02:46
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07413046-30f9-42c0-94fc-88118a1cb5fd

📥 Commits

Reviewing files that changed from the base of the PR and between b9ec780 and 049dd35.

📒 Files selected for processing (1)
  • .github/workflows/detect-agent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/detect-agent.yml

📝 Walkthrough

Walkthrough

The pull request removes the .github/workflows/detect-agent.yml GitHub Actions workflow file. This workflow previously contained two jobs—detect triggered on pull request creation and backfill triggered manually—that delegated execution to reusable workflows maintained in the bombshell-dev/automation repository.

Changes

Cohort / File(s) Summary
Workflow Removal
.github/workflows/detect-agent.yml
Deleted the entire detect-agent workflow configuration (23 lines removed). This workflow previously defined detect and backfill jobs that dispatched to external automation reusable workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • TkDodo

Poem

🐰 A workflow once stood proud and tall,
Detecting changes, backfilling all,
But now it's gone with a simple delete,
The automation flow is now complete!
No more reusable jobs to call. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the detect-agent workflow from CI configuration.
Description check ✅ Passed The description includes all required sections (Changes, Checklist, Release Impact) with complete information about the rationale and impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/remove-detect-agent-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 25, 2026

View your CI Pipeline Execution ↗ for commit 049dd35

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-25 02:49:44 UTC

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/query-devtools 5.100.14 → 5.100.15 Changeset
@tanstack/angular-query-experimental 5.100.14 → 5.100.15 Dependent
@tanstack/angular-query-persist-client 5.100.14 → 5.100.15 Dependent
@tanstack/eslint-plugin-query 5.100.14 → 5.100.15 Dependent
@tanstack/lit-query 0.2.6 → 0.2.7 Dependent
@tanstack/preact-query 5.100.14 → 5.100.15 Dependent
@tanstack/preact-query-devtools 5.100.14 → 5.100.15 Dependent
@tanstack/preact-query-persist-client 5.100.14 → 5.100.15 Dependent
@tanstack/query-async-storage-persister 5.100.14 → 5.100.15 Dependent
@tanstack/query-broadcast-client-experimental 5.100.14 → 5.100.15 Dependent
@tanstack/query-core 5.100.14 → 5.100.15 Dependent
@tanstack/query-persist-client-core 5.100.14 → 5.100.15 Dependent
@tanstack/query-sync-storage-persister 5.100.14 → 5.100.15 Dependent
@tanstack/react-query 5.100.14 → 5.100.15 Dependent
@tanstack/react-query-devtools 5.100.14 → 5.100.15 Dependent
@tanstack/react-query-next-experimental 5.100.14 → 5.100.15 Dependent
@tanstack/react-query-persist-client 5.100.14 → 5.100.15 Dependent
@tanstack/solid-query 5.100.14 → 5.100.15 Dependent
@tanstack/solid-query-devtools 5.100.14 → 5.100.15 Dependent
@tanstack/solid-query-persist-client 5.100.14 → 5.100.15 Dependent
@tanstack/svelte-query 6.1.33 → 6.1.34 Dependent
@tanstack/svelte-query-devtools 6.1.33 → 6.1.34 Dependent
@tanstack/svelte-query-persist-client 6.1.33 → 6.1.34 Dependent
@tanstack/vue-query 5.100.14 → 5.100.15 Dependent
@tanstack/vue-query-devtools 6.1.33 → 6.1.34 Dependent

@sukvvon sukvvon self-assigned this May 25, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 25, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10781

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10781

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10781

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10781

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10781

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10781

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10781

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10781

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10781

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10781

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10781

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10781

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10781

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10781

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10781

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10781

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10781

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10781

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10781

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10781

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10781

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10781

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10781

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10781

commit: 049dd35

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 12.11 KB (0%)
react minimal 9.08 KB (0%)

@TkDodo TkDodo merged commit 7252bdc into main May 25, 2026
9 checks passed
@TkDodo TkDodo deleted the ci/remove-detect-agent-workflow branch May 25, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants