fix(mcp): serialize multiple databases in list_connections and add list_databases tool#426
Open
erneztox wants to merge 1 commit into
Open
fix(mcp): serialize multiple databases in list_connections and add list_databases tool#426erneztox wants to merge 1 commit into
erneztox wants to merge 1 commit into
Conversation
…st_databases tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! As discussed in the issue, here is the PR to improve the MCP server database discovery.
What changed?
list_connectionsarray serialization: Insrc-tauri/src/mcp/mod.rs, changed thedatabaseproperty extraction from.to_string()(which called.primary()and dropped items) to.as_vec(). Now the MCP client correctly sees all databases configured in a single connection.list_databasestool: Added a nativelist_databasestool leveraging the existingdriver.get_databases()trait. This allows the LLM to query and discover all available databases natively through the connection without needing to manually run SQL queries.Testing
tabularis --mcpbinary.list_connectionsoutputs the full array.list_databasesconnects to the engine and returns the schemas correctly.cargo check.Let me know if you need any adjustments!