feat: add multi speed fast forward (1x-16x) to game menu#1115
Open
mdevolde wants to merge 1 commit intoSwordfish90:masterfrom
Open
feat: add multi speed fast forward (1x-16x) to game menu#1115mdevolde wants to merge 1 commit intoSwordfish90:masterfrom
mdevolde wants to merge 1 commit intoSwordfish90:masterfrom
Conversation
|
Thanks @mdevolde looks like a nice PR 😊 Two questions:
|
|
Based on my reading of the description, this does not add a button/key binding. I also really want that feature. #1077 seems to add this feature though! But so far the PR has been ignored. If you end up building lemuroid with that PR could you share the APK? Or maybe I will try building it myself at some point... |
Author
|
@mgiessing @kovasap I didn't add a shortcut for "fast-forward" because it is yet implemented, but I didn't notice that, because this shortcut has no default value, it is impossible to configure it. I will look at this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add multi speed fast forward (1x-16x) to game menu
Motivations
The purpose of this PR is to allow players to have more options when adjusting the game speed (which is currently limited to x1 or x2).
Changes
Interface changes
ListPreferencewith the same speeds as above.On both platforms, displays the note “Some speeds may be limited depending on the core.”
Code changes
EXTRA_FRAME_SPEEDextra and aRESULT_SET_FRAME_SPEEDresult.BaseGameActivityapplies it toretroGameView.frameSpeed.EXTRA_FAST_FORWARD/RESULT_ENABLE_FAST_FORWARD.Testing
Related issues
Closes #650
Closes #837