chore: tidy repo root monitoring and benchmarks#300
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
chore: tidy repo root monitoring and benchmarks#300devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced May 14, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This completes task 7 of the v3.1.0 hygiene pass: repo-root tidy with no public API removal. It moves monitoring implementation/demo files under
tools/monitoring/, benchmark artifacts underbenchmarks/, and ACVP evidence underdocs/compliance/; preserves the historicalama_cryptography_monitortop-level module via a compatibility shim; deletes.test-push; and updates references, per-file ignores, packaging, CI artifact paths, and integrity digest metadata.Follow-up commit
3061ca2keeps the shim statically explicit enough for GitHub Advanced Security / CodeQL while preserving the runtimesys.modulesalias behavior used by existing monitor tests.Type of Change
Related Issues
Relates to v3.1.0 hygiene task 7.
Motivation and Context
Why is this change required?
The v3.1.0 hygiene checklist calls for moving root-level tooling/evidence artifacts into domain directories while preserving API compatibility.
What problem does it solve?
It reduces repo-root clutter and makes monitoring, benchmarking, and compliance evidence locations explicit without changing cryptographic behavior or removing the historical monitor import path.
Cryptographic Impact
Security Impact Assessment
Standards Compliance
Academic References
N/A — no cryptographic algorithm changes.
Security Analysis
Classical Security: No change.
Quantum Security: No change.
Security Impact: Maintains current posture; only file organization, docs, packaging metadata, and CI paths changed.
Implementation Details
Changes Made
ama_cryptography_monitor.pyimplementation and demo totools/monitoring/; added a root compatibility shim forpy_modules=["ama_cryptography_monitor"].benchmark_suite.pyandbenchmark-results.jsontobenchmarks/; movedCSRC_ALIGN_REPORT.mdtodocs/compliance/; deleted.test-push.tools/update_docs.py,pyproject.toml,setup.py, and regeneratedama_cryptography/_integrity_digest.txtafter legitimate package-source edits.Technical Approach
Use pure relocation plus compatibility shims. The historical top-level
ama_cryptography_monitorimport remains accepted and resolves to the relocated implementation; package metadata includestools.*packages so packaged installs can still import the relocated module.Breaking Changes
Breaking Changes:
Migration Path:
No migration required. Existing
from ama_cryptography_monitor import ...imports continue to work.Testing
Test Coverage
Testing Performed
Environment:
Test Cases:
python3 -m pytest tests/— 2172 passed, 4 skipped.python3 -m ruff check .— passed.python3 -m mypy ama_cryptography/ ama_cryptography_monitor.py tools/monitoring/ama_cryptography_monitor.py tools/monitoring/ama_cryptography_monitor_demo.py— passed.Known Test Vectors
Code Quality
Code Quality Checks
black .)ruff check .)mypy ama_cryptography/)Documentation Updates
Backwards Compatibility
Compatibility Assessment
Deprecation Notices
Deprecated Features:
Deprecation Timeline:
Performance Impact
Performance Analysis
Benchmarks: Not performance-related.
Impact:
Link to Devin session: https://app.devin.ai/sessions/380c3bcb95034d1f83fb66062f20e8cf
Requested by: @Steel-SecAdv-LLC