docs: add nosec disposition and invariant pointer - #297
Closed
devin-ai-integration[bot] wants to merge 3 commits into
Closed
docs: add nosec disposition and invariant pointer#297devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
devin-ai-integration
Bot
requested a review
from Steel-SecAdv-LLC
as a code owner
May 14, 2026 04:35
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced May 14, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
Adds the requested hygiene gate work before any
# nosecremovals:# nosecaudit innosec_disposition.mdwith one row per occurrence found in scope, plus the single additional test-suite occurrence needed for the acceptance criterion.# nosecsuppressions intact pending disposition review.INVARIANTS.mdcanonical and replaces.github/INVARIANTS.mdwith a 3-line pointer..github/INVARIANTS.mdbecomes a divergent duplicate again.v*tag trigger toacvp_validation.yml, matchingsecurity.ymlrelease-tag behavior.25296298536) and PR ci: Bump github/codeql-action from 4.35.2 to 4.35.4 #293 (75341760035) show the same macOS 3.10 job can pass on this code path.Type of Change
Related Issues
Relates to v3.1.0 nosec hygiene audit.
Motivation and Context
Why is this change required?
The v3.1.0 hygiene pass requires a reviewed
# nosecdisposition table before suppressions are removed, and the duplicated invariants documents had identical content that could drift silently.What problem does it solve?
This creates the review artifact for subsequent per-file remediation PRs and preserves a single canonical invariants document while retaining the
.github/INVARIANTS.mdpath as a pointer.Cryptographic Impact
Security Impact Assessment
Standards Compliance
Academic References
N/A — no cryptographic construction changed.
Security Analysis
Classical Security: No primitive, key-management, KAT, or constant-time implementation changes.
Quantum Security: No PQC implementation changes.
Security Impact: Maintains current posture; adds audit documentation and CI guardrails.
Implementation Details
Changes Made
nosec_disposition.mdcovering every# nosecfound inama_cryptography/,tools/,benchmarks/,examples/, plus the repo-wide test fixture occurrence..github/INVARIANTS.mdwith a 3-line pointer to rootINVARIANTS.md.tools/check_version_consistency.pyand tests to enforce the pointer and root canonical document.tags: ['v*']toacvp_validation.ymlso future release tags trigger ACVP validation.Technical Approach
Keep this PR limited to review artifacts, docs pointer cleanup, and CI guardrails. No public API, C source, constant-time function, KAT vector, or build-system floor was changed.
Breaking Changes
Breaking Changes:
Migration Path:
N/A.
Testing
Test Coverage
Testing Performed
Environment:
Test Cases:
python tools/check_version_consistency.pypytest tests/test_version_consistency.py tests/test_invariant_upgrades.py -qKnown Test Vectors
Code Quality
Code Quality Checks
black .)ruff check .)mypy ama_cryptography/)Documentation Updates
Backwards Compatibility
Compatibility Assessment
Deprecation Notices
Deprecated Features:
Deprecation Timeline:
Performance Impact
Performance Analysis
Benchmarks:
N/A.
Impact:
Release Notes
No version bump. Source remains v3.1.0.
Link to Devin session: https://app.devin.ai/sessions/380c3bcb95034d1f83fb66062f20e8cf
Requested by: @Steel-SecAdv-LLC