Fix Packagist self-replace error blocking package updates#105
Conversation
…orts icon addon type requires an <extends> tag; without it validateMetainfo rejects the component and skips icon export. generic is the correct type for a PHP library, and allows appstream-generator to publish the stock icon to the DEP-11 media dir so Mastodon announcements can attach it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…o v2026.3.11 Remove invalid replace.spojenet/flexibee self-reference from composer.json that was causing Packagist to skip the main branch entirely; also apply CS-fixer reformatting and regenerated Actions/EvidenceList/Formats/Relations/RO from AbraFlexi server v2026.3.11. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR updates the AbraFlexi library to version 2026.3.14, coordinating source version constants, code documentation refinements, package metadata adjustments, and evidence variant property configuration reordering across static schema definitions. ChangesVersion 2026.3.14 Release with Evidence Variant Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.54)Composer install failed: this project depends on private packages that require authentication (e.g. GitLab/GitHub, Laravel Nova, etc.). Instead, run PHPStan in a CI/CD pipeline where you can use custom packages — our pipeline remediation tool can use the PHPStan output from your CI/CD pipeline. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/AbraFlexi/RO.php`:
- Around line 1869-1871: Update the PHPDoc for the method that declares
parameters $columnsList, $conditions and $indexBy so it matches actual runtime
handling: change $columnsList from "array<string>|string" to
"array<int|string>|int|string" (to allow integer column IDs or a single int),
change $conditions from "array<int|string, mixed>" to "array<int|string,
mixed>|int|string" (to allow string filters and integer record IDs), and keep
$indexBy as "null|string"; then save and re-run static analysis to ensure no
type mismatches remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4f9df872-4712-4375-a8cb-b6290d55d3c3
📒 Files selected for processing (23)
composer.jsondebian/io.github.spoje_net.php_spojenet_abraflexi.metainfo.xmlsrc/AbraFlexi/Actions.phpsrc/AbraFlexi/EvidenceList.phpsrc/AbraFlexi/Formats.phpsrc/AbraFlexi/RO.phpsrc/AbraFlexi/Relations.phpstatic/Properties.atribut.jsonstatic/Properties.castky-k-odpoctu.jsonstatic/Properties.cislo-baliku.jsonstatic/Properties.doporuceni.jsonstatic/Properties.neuhrazene-po-splatnosti-2.jsonstatic/Properties.neuhrazene-po-splatnosti.jsonstatic/Properties.prikaz-k-inkasu-polozka.jsonstatic/Properties.prikaz-k-uhrade-polozka.jsonstatic/Properties.priloha.jsonstatic/Properties.prodejka-platba.jsonstatic/Properties.rezervace.jsonstatic/Properties.splatkovy-kalendar.jsonstatic/Properties.udalost.jsonstatic/Properties.vyrobni-cislo.jsonstatic/Properties.zaloha-k-odpoctu.jsontests/src/AbraFlexi/ParseErrorEmptyResultsTest.php
💤 Files with no reviewable changes (1)
- composer.json
| * @param array<string>|string $columnsList List of items or detail level: id|summary|full | ||
| * @param array<int|string, mixed> $conditions Array of conditions or record ID | ||
| * @param null|string $indexBy Column by which to index records |
There was a problem hiding this comment.
PHPDoc types no longer match the implemented input contract.
Line 1869 excludes int for $columnsList, but Line 1883 explicitly handles integer input.
Line 1870 excludes string for $conditions, but Line 1919 accepts string filters.
Please align the docblock with actual accepted inputs to avoid misleading static analysis and callers.
Suggested docblock fix
- * `@param` array<string>|string $columnsList List of items or detail level: id|summary|full
- * `@param` array<int|string, mixed> $conditions Array of conditions or record ID
+ * `@param` array<string>|int|string $columnsList List of items, record ID, or detail level: id|summary|full
+ * `@param` array<int|string, mixed>|int|string $conditions Array of conditions, filter string, or record ID📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * @param array<string>|string $columnsList List of items or detail level: id|summary|full | |
| * @param array<int|string, mixed> $conditions Array of conditions or record ID | |
| * @param null|string $indexBy Column by which to index records | |
| * `@param` array<string>|int|string $columnsList List of items, record ID, or detail level: id|summary|full | |
| * `@param` array<int|string, mixed>|int|string $conditions Array of conditions, filter string, or record ID | |
| * `@param` null|string $indexBy Column by which to index records |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/AbraFlexi/RO.php` around lines 1869 - 1871, Update the PHPDoc for the
method that declares parameters $columnsList, $conditions and $indexBy so it
matches actual runtime handling: change $columnsList from "array<string>|string"
to "array<int|string>|int|string" (to allow integer column IDs or a single int),
change $conditions from "array<int|string, mixed>" to "array<int|string,
mixed>|int|string" (to allow string filters and integer record IDs), and keep
$indexBy as "null|string"; then save and re-run static analysis to ensure no
type mismatches remain.
1 participant
Summary
replace.spojenet/flexibee: self.versionfromcomposer.json— a package cannot replace itself, and Packagist was skipping themainbranch with the error "a package cannot set a replace on itself", preventing all new releases from appearing.Actions,EvidenceList,Formats,Relations, andROfrom AbraFlexi server v2026.3.11 with CS-fixer formatting applied.Test plan
composer validate— should report no errors incomposer.jsonmainbranch and new tags without skipping them🤖 Generated with Claude Code
Summary by CodeRabbit