refactor: Do not use id for mouse and rename TouchState to PointerState#51
Open
leomeinel wants to merge 3 commits intoSergioRibera:mainfrom
Open
refactor: Do not use id for mouse and rename TouchState to PointerState#51leomeinel wants to merge 3 commits intoSergioRibera:mainfrom
leomeinel wants to merge 3 commits intoSergioRibera:mainfrom
Conversation
Bevy does not assign ids to mouse input, therefore storing one is unnecessary. By inserting None for id if we are using a mouse, we can also just use that to check if input is from a mouse which seems a lot cleaner. Additionally this avoids previously duplicated checks in one of the branches by just first processing touch and mouse in the else branch.
TouchState suggests that this is only four touches, but it actually is for any pointer.
leomeinel
changed the title
leomeinel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bevy does not assign ids to mouse input, therefore storing one is unnecessary.
By inserting None for id if we are using a mouse, we can also just use that to check if input is from a mouse which seems a lot cleaner.
Additionally this avoids previously duplicated checks in one of the branches by just first processing touch and mouse in the else branch.
Edit
I have now also renamed
TouchStatetoPointerStatesince TouchState suggests that it is only four touches, but it actually is for any pointer.Additionally and slightly out of the scope of this pr, I have also made sure that we are not calling node_rect unnecessarily which required a small refactor of the else branch in update_input.
Testing
This has been tested on mobile with the
simple_mobileexample and on linux with thesimpleexample.