Skip to content

Filter FINBoosterFactory.BorderlessCharacter to remove duplicate Kuja#979

Closed
ProdigySim wants to merge 1 commit into
Senryoku:masterfrom
ProdigySim:patch-1
Closed

Filter FINBoosterFactory.BorderlessCharacter to remove duplicate Kuja#979
ProdigySim wants to merge 1 commit into
Senryoku:masterfrom
ProdigySim:patch-1

Conversation

@ProdigySim
Copy link
Copy Markdown

Kuja FIN 399 is duplicated in this data set as scryfall tracks a variant of this card.

I applied a similar fix as the one for FCA in this same booster factory.

Fixes #978

… 399

Filter BorderlessCharacter to include only valid collector numbers.
@ProdigySim ProdigySim marked this pull request as draft May 7, 2026 05:52
@ProdigySim
Copy link
Copy Markdown
Author

Looks like Kuja is still sneaking in from the Borderless collection as well. I will work on a better fix and try to find a place to add some testing or assert()

@ProdigySim ProdigySim closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FINBoosterFactory produces twice as many Kuja 399 as expected

1 participant