Skip to content

Quick Fix: discover hidden columns in Sqlite#2996

Closed
sinder38 wants to merge 1 commit intoSeaQL:masterfrom
sinder38:quick-fix/sqlite-hidden-columns
Closed

Quick Fix: discover hidden columns in Sqlite#2996
sinder38 wants to merge 1 commit intoSeaQL:masterfrom
sinder38:quick-fix/sqlite-hidden-columns

Conversation

@sinder38
Copy link
Copy Markdown
Contributor

@sinder38 sinder38 commented Mar 10, 2026

PR Info

This is a quick fix. real bug is in sea_scheme SchemaDiscovery::discover_with()

Bug Fixes

  • schema sync doesn't detect hidden columns is sqlite

Changes

  • Add a temporary raw query to check for hidden columns

@sinder38 sinder38 force-pushed the quick-fix/sqlite-hidden-columns branch from d9ef425 to cb33b05 Compare March 10, 2026 16:27
@sinder38 sinder38 marked this pull request as draft March 10, 2026 16:30
@sinder38 sinder38 closed this Mar 10, 2026
@sinder38 sinder38 force-pushed the quick-fix/sqlite-hidden-columns branch from cb33b05 to 50ef02c Compare March 10, 2026 16:35
@sinder38 sinder38 reopened this Mar 10, 2026
@sinder38 sinder38 marked this pull request as ready for review March 10, 2026 16:38
@sinder38
Copy link
Copy Markdown
Contributor Author

now that I think of I probably should have just made a fix to sea-schema without doing this...

@Huliiiiii
Copy link
Copy Markdown
Member

Yes, we should fix this in sea schema. This is too hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column extra causes sync to add column again

2 participants