Conform with templating + linting practices + repo-review#6927
Conform with templating + linting practices + repo-review#6927trexfeathers wants to merge 18 commits intoSciTools:mainfrom
Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Templated files
The following changed files are templated:
-
.pre-commit-config.yaml, templated bySciTools/.github/templates/.pre-commit-config.yaml -
benchmarks/asv_delegated.py, templated bySciTools/.github/templates/benchmarks/asv_delegated.py -
pyproject.toml, templated bySciTools/.github/templates/pyproject.toml
Template candidates
The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
| ignore = [ | ||
| # NOTE: Non-permanent exclusions should be added to the ".ruff.toml" file. |
There was a problem hiding this comment.
We discussed this at length while producing this wiki page:
https://github.com/SciTools/.github/wiki/Linting
We agreed that we preferred to keep everything within pyproject.toml
If this is merged, some updates will be needed to the text of #5625
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6927 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 91 91
Lines 24951 24951
Branches 4683 4683
=======================================
Hits 22488 22488
Misses 1684 1684
Partials 779 779 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 57a9279.
|
Note this PR has actually actioned MORE of the desirable files than expected, due to a temporary mistake in my pre-commit configuration. Later on we need to explore improving the pre-commit file filters, as the current ones in the template are too restrictive when it comes to non-Python files. But the scope of this pull request is already quite wide, so I would prefer not to do so here. If the reviewer is happy I will raise an issue against the main template in SciTools/.github. |
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: