feat: add generic wheel scroll and press commands#744
Open
Keith94 wants to merge 2 commits intoSamillion:mainfrom
Open
feat: add generic wheel scroll and press commands#744Keith94 wants to merge 2 commits intoSamillion:mainfrom
Keith94 wants to merge 2 commits intoSamillion:mainfrom
Conversation
Owner
|
Terribly sorry about the delay. The code looks good. Do you need me to do any testing? As I explained in the other PR I'm dealing with urgent matters right now, unfortunately I cannot help immediately. I might need three or four more days before being able to focus here again. If this is merge ready, please let me know and I'll do so without waiting as I trust your work. |
Contributor
Author
|
I think I'll try a different approach soon that doesn't add any user options. No rush for merging it, can review it when you get a chance. Edit: #747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands set as default actions are applied to elements that have no explicit command defined.
Reference: #698