Fix home page book display issues#18
Merged
RespectMathias merged 34 commits intomainfrom May 22, 2025
Merged
Conversation
Fixed that runserver did not work with activate, so calling executable directly
Added: - Automatic csv download. - Using django from venv
- Fixed book ratings to show varied values instead of all 5.0 - Resolved duplicate books issue with unique book ID tracking - Improved title display with two-line height for better readability - Enhanced score calculation with better date handling and ID variation - Made recency calculation more robust for different date formats These changes ensure the home page accurately reflects book data while maintaining a clean, consistent UI with TailwindCSS and DaisyUI.
Fixed that runserver did not work with activate, so calling executable directly
Added: - Automatic csv download. - Using django from venv
Added: - Rebased with main - Fixed login related pages by properly using django.contrib.auth - Additional pages
Fixed: - Readded Wasi's styling
…to improvement
Added: - Admin panel button for superusers so you don't need to navigate via url
Added: - bfs unit tests - cbf unit tests
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fixed: - Crossplatform paths - Book ids instead of titles to get instances for cbf - print into comment because we don't need to log this since it will get returned empty
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improvement
- Fixed book ratings to show varied values instead of all 5.0 - Resolved duplicate books issue with unique book ID tracking - Improved title display with two-line height for better readability - Enhanced score calculation with better date handling and ID variation - Made recency calculation more robust for different date formats These changes ensure the home page accurately reflects book data while maintaining a clean, consistent UI with TailwindCSS and DaisyUI.
Fixed: - Undo top-k changes and instead fix the issue at its source, the duplicate data from the csv
…Undershelf into feature/fix-book-display
undo top k (Which i did but git sucks)
RespectMathias
approved these changes
May 22, 2025
Contributor
RespectMathias
left a comment
RespectMathias
left a comment
There was a problem hiding this comment.
Rebased to be up to date with main. Fixed duplicate data from import. And kept your changes to the index page. Undone changes to top-k since issue was data import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes ensure the home page accurately reflects book data while maintaining a clean, consistent UI with TailwindCSS and DaisyUI.