feat(number-input): introduce number-input module#4
Open
ditoglez wants to merge 1 commit into
Open
Conversation
ditoglez
changed the title
ditoglez
force-pushed
the
enhancement/2
branch
from
e2f0871 to
ce2679a
Compare
Member
|
See discussion in #2 |
ditoglez
force-pushed
the
enhancement/2
branch
from
1968efd to
1ef71cf
Compare
Member
|
Is there a good reason we are copying the testing utilities from |
Member
|
@ditoglez This also still has the |
ditoglez
force-pushed
the
enhancement/2
branch
from
1ef71cf to
83bb5dd
Compare
ditoglez
force-pushed
the
enhancement/2
branch
3 times, most recently
from
45da85e to
fa02d35
Compare
ditoglez
changed the title
flore2003
requested changes
Sep 7, 2018
flore2003
left a comment
flore2003
left a comment
Member
There was a problem hiding this comment.
Can you update this PR and solve the conflicts it has with master?
ditoglez
force-pushed
the
enhancement/2
branch
from
fa02d35 to
d145a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds number-input module to the library, unit tests.
Closes #2