Skip to content

fix: ActionSheet cuts off the bottom content#7326

Open
OtavioStasiak wants to merge 2 commits into
developfrom
fix.action-sheet-bottom-low-height-devices
Open

fix: ActionSheet cuts off the bottom content#7326
OtavioStasiak wants to merge 2 commits into
developfrom
fix.action-sheet-bottom-low-height-devices

Conversation

@OtavioStasiak
Copy link
Copy Markdown
Contributor

@OtavioStasiak OtavioStasiak commented May 15, 2026

Proposed changes

Fixes a bottom-clipping regression in action sheets that render arbitrary children (not the predefined options list) on devices without a home-indicator safe-area inset — most visibly iPhone SE, where the Add Server button in the Workspaces sheet was cut off.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-1040

How to test or reproduce

  • Boot the iPhone SE (3rd generation) simulator (or any device ≤ 667px tall with no home indicator).
  • Log in to any workspace.
  • On the Rooms List, tap the server name in the header → the Workspaces action sheet opens.
  • Repeat it with two and three workspaces;
  • Click on add Workspace;
  • On NewServerView check the ServersHistory;

Screenshots

Servers List

Before After
Simulator Screenshot - iPhone SE (3rd generation) - 2026-05-15 at 11 15 40 Simulator Screenshot - iPhone SE (3rd generation) - 2026-05-15 at 11 47 59

Servers History

Before After
Simulator Screenshot - iPhone SE (3rd generation) - 2026-05-15 at 11 15 50 Simulator Screenshot - iPhone SE (3rd generation) - 2026-05-15 at 11 47 41

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • New Features

    • Added end-to-end tests for small-screen device scenarios covering servers history and servers list functionality.
  • Bug Fixes

    • Fixed action sheet height calculation to properly account for handle dimensions.
  • Chores

    • Expanded Android testing infrastructure with additional test shard.
    • Improved iOS simulator device selection for test execution.
    • Enhanced Android test filtering to exclude iOS-specific flows.

Review Change Stack

@OtavioStasiak OtavioStasiak temporarily deployed to approve_e2e_testing May 15, 2026 14:55 — with GitHub Actions Inactive
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Walkthrough

This PR adds comprehensive small-screen regression test coverage for action sheets and server navigation, expands test infrastructure to support 14 shards with device-specific simulator selection, excludes iOS-only flows from Android runs, and refines ActionSheet height calculations to account for the handle component.

Changes

Small-Screen UI Testing and ActionSheet Rendering

Layer / File(s) Summary
Maestro Test Infrastructure
.github/scripts/run-maestro.sh, .github/workflows/build-pr.yml, .github/workflows/maestro-ios.yml
Maestro script now excludes ios-only tagged flows during Android test runs and reruns; shard matrix expanded to 14; iOS workflow conditionally boots iPhone SE (3rd gen) for shard 14 and iPhone 16 Pro otherwise.
Small-Screen Regression Tests
.maestro/tests/onboarding/servers-history-small-screen.yaml, .maestro/tests/room/servers-list-small-screen.yaml
New test flows verify Servers History and Servers List action sheets render and remain unclipped on small screens, including user creation, deeplink login, action sheet interaction, and layout assertions.
ActionSheet Detent Calculation
app/containers/ActionSheet/useActionSheetDetents.ts, app/containers/ActionSheet/useActionSheetDetents.test.tsx
Hook updated to include HANDLE_HEIGHT in detent numerator for content-based heights; test expectations adjusted to match new calculation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'fix: ActionSheet cuts off the bottom content' directly aligns with the main change—fixing a bottom-clipping issue in action sheets on low-height devices.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OtavioStasiak OtavioStasiak marked this pull request as ready for review May 15, 2026 14:58
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build May 15, 2026 14:58 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build May 15, 2026 14:58 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build May 15, 2026 14:58 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak changed the title Fix.action sheet bottom low height devices fix: ActionSheet cutting off the bottom of content May 15, 2026
@OtavioStasiak OtavioStasiak changed the title fix: ActionSheet cutting off the bottom of content ix: ActionSheet cuts off the bottom content May 15, 2026
@OtavioStasiak OtavioStasiak changed the title ix: ActionSheet cuts off the bottom content fix: ActionSheet cuts off the bottom content May 15, 2026
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build May 15, 2026 16:58 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build May 15, 2026 16:58 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_ios_build May 15, 2026 16:58 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant