fix: ActionSheet cuts off the bottom content#7326
Conversation
WalkthroughThis PR adds comprehensive small-screen regression test coverage for action sheets and server navigation, expands test infrastructure to support 14 shards with device-specific simulator selection, excludes iOS-only flows from Android runs, and refines ActionSheet height calculations to account for the handle component. ChangesSmall-Screen UI Testing and ActionSheet Rendering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Fixes a bottom-clipping regression in action sheets that render arbitrary children (not the predefined options list) on devices without a home-indicator safe-area inset — most visibly iPhone SE, where the Add Server button in the Workspaces sheet was cut off.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-1040
How to test or reproduce
Screenshots
Servers List
Servers History
Types of changes
Checklist
Further comments
Summary by CodeRabbit
New Features
Bug Fixes
Chores