chore: Merge master into develop#7315
Conversation
* add custom fields after register * remove tmid when it is null * wip * wip * wip
* Regression: Create private team and channel as default * minor tweak
* fix multiselect itens style * remove useless brackets * remove scroll from the top of the list items
# Conflicts: # __tests__/containers/List/__snapshots__/List.stories.storyshot # __tests__/containers/SearchBox/__snapshots__/SearchBox.stories.storyshot # __tests__/containers/TextInput/__snapshots__/TextInput.stories.storyshot # android/app/build.gradle # android/build.gradle # app/containers/TextInput/TextInput.stories.tsx # app/containers/message/Audio.tsx # app/lib/methods/audioFile.ts # app/views/CreateChannelView/index.tsx # app/views/DefaultBrowserView/index.tsx # app/views/NotificationPreferencesView/index.tsx # app/views/RoomMembersView/components/ActionsSection.tsx # app/views/RoomMembersView/index.tsx # e2e/data.ts # e2e/data/data.cloud.ts # e2e/data/data.docker.ts # e2e/helpers/data_setup.ts # e2e/tests/assorted/07-changeserver.spec.ts # e2e/tests/assorted/11-deeplinking.spec.ts # e2e/tests/onboarding/05-login.spec.ts # ios/Podfile.lock # ios/RocketChatRN.xcodeproj/project.pbxproj # ios/RocketChatRN/AppDelegate.h # ios/RocketChatRN/AppDelegate.mm # ios/RocketChatRN/Info.plist # ios/ShareRocketChatRN/Info.plist # package.json # yarn.lock
Merge 4.31.0 into master
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* migrate settings view to hooks * temp - add non-null assertion * fix options * Update app/views/SettingsView/index.tsx Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * Update app/views/SettingsView/index.tsx Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix options Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
* fix layout * fix quote * update snapshot
…me (#4576) * [FIX] Touch/Face ID toggle does not enable automatically the first time * minor tweak no competition setState
* button ignore and pased the param * load room from database and check is is ignored * move handleIgnore to lib/method/helpers * Ignore and Unignore, also reactivity * block and unblock user * pass fromRid from actionView to InfoView too * remove console.log * unsubscribe subscriptionFrom * block and unblock user from dm * test to block user and ignore user * minor tweak * tweak data * minor tweak * add test before tapBack * refactor names
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
* [FIX] Screen Lock's Password screen UI is broken on tablets * minor tweak and added comment * minor tweak * minor tweak * minor tweak
* fix sys messages * update snapshot * update snapshot * add username * wip * wip * change to switch and fix types * wip * new translations * update snapshot * Update app/containers/message/utils.ts Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix types and return * remove unused translation * fix types * remove unused params * minor tweak * update story Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Co-authored-by: Reinaldo Neto <reinaldonetof@hotmail.com>
* [FIX] UiKit/DatePicker is broken * minor tweak
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* [IMPROVE] Spotlight users order * minor tweak query * minor tweak removing query and using regex * minor tweak * minor tweak, make ts happy * fix the ts * fix lint and type TSearch
* TC-110 [FIX] Cancelling when adding a server * Removing the close button when connecting to a server
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
WalkthroughIntroduces ChangesNotification Intent Routing
Sequence DiagramsequenceDiagram
participant MainActivity
participant NotificationIntentHandler
participant VoipNotification
participant VideoConfModule
participant PushNotificationModule
MainActivity->>NotificationIntentHandler: handleIntent(context, intent)
NotificationIntentHandler->>VoipNotification: handleMainActivityVoipIntent(context, intent)
alt VoIP handled
VoipNotification-->>NotificationIntentHandler: true
else Check video-conf action
VoipNotification-->>NotificationIntentHandler: false
alt videoConfAction flag set
NotificationIntentHandler->>VideoConfModule: handleVideoConfIntent
else Regular notification
NotificationIntentHandler->>PushNotificationModule: handleNotificationIntent
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — wrong direction. Conflicts will be resolved on the 4.72.0-master release branch instead. |
Proposed changes
Sync
master(4.71.2) hotfix history intodevelopahead of the 4.72.0 release merge (#7314), which currently has conflicts.Conflict resolution:
package.json,android/app/build.gradle,ios/RocketChatRN/Info.plist,ios/ShareRocketChatRN/Info.plist,ios/RocketChatRN.xcodeproj/project.pbxproj) → resolved to develop (4.72.0).app/views/ChangePasscodeView.tsxandapp/views/ScreenLockedView.tsx→ kept develop's layout (rerere). Master's older centering CSS would reintroduce the regression fixed by regression: lock screen no longer appears full screen #7118.yarn.lock→ resolved to develop (axios is at 0.30.3 on both branches; only diff was a strayflow-parserblock).Net diff against
developis a single trailing-newline cleanup inNotificationIntentHandler.kt.After this lands, #7314 (
develop→masterfor 4.72.0) should become conflict-free.Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit