fix: emoji picker scroll does not reach the end#7312
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughPlatform-agnostic bottom-sheet padding for the emoji grid, a Maestro regression test that scrolls to and selects the last emoji, and minor non-semantic EOF/format tweaks to iOS plist and Xcode project files. ChangesEmoji Picker Accessibility
iOS EOF / formatting housekeeping
Sequence Diagram(s)sequenceDiagram
participant User
participant Message
participant ActionSheet
participant EmojiPicker
participant EmojiGrid
User->>Message: long-press message
Message->>ActionSheet: open actions
ActionSheet->>EmojiPicker: tap add reaction
EmojiPicker->>EmojiGrid: switch to emoji tab
EmojiGrid->>EmojiGrid: swipe up until emoji-pregnant_woman visible
User->>EmojiGrid: tap emoji-pregnant_woman
EmojiGrid->>Message: display message-reaction-:pregnant_woman:
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
left a comment
There was a problem hiding this comment.
Missing e2e tests passing.
Proposed changes
Fix an issue in the emoji picker where users couldn’t scroll all the way down or tap the last row of emojis on devices with smaller screen heights.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-1030
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Tests
Bug Fixes
Chores