chore: stabilize Maestro CI (Maestro 2.5.1, emulator headroom)

[diegolmello]

Proposed changes

CI stabilization (original scope)

• Maestro CLI 2.2.0 → 2.5.1 in both Android and iOS workflows. 2.5.0 switched gRPC to dadb's direct ADB socket, eliminating the Broken pipe install class that has been the dominant Android Maestro shard failure mode.
• Drop the Android monkey warmup (and its trailing sleep 6 + am force-stop) in run-maestro.sh — the warmup was stressing system_server immediately before Maestro's driver install attempt.
• Broaden iOS job-level retry from retry_on: timeout to retry_on: error.
• Bump Android emulator RAM 4G → 6G on every reactivecircus/android-emulator-runner invocation (ubuntu-latest has 16 GB total — leaves comfortable headroom).
• Pre-launch disk cleanup via jlumbroso/free-disk-space@v1.3.1 (Android SDK and tool cache preserved; ~6 GB freed).
• Explicit AVD snapshot caching for the default profile (shards 1–13): cache miss → boot once with force-avd-creation: true to seed the snapshot, cache hit → replay with force-avd-creation: false and -no-snapshot-save to prevent corruption. Keyboard AVD path (shard 14) untouched — has its own manual recreation each run.

The bespoke per-failed-flow JUnit retry loop in run-maestro.sh is intentionally retained — it reruns only failed flows, which is strictly better than any native Maestro mechanism (no --retry CLI flag in 2.5.1; YAML retry: block restarts whole flow).

Android job-level retry wrapper deferred — nick-fields/retry@v3 only wraps shell commands, not uses: actions; will revisit in a follow-up.

Sidebar testID fix (folded in)

PR #6918 (Voice support, cd2faa0) collapsed the SidebarView wrapper — testID='sidebar-view' moved from a SafeAreaView onto the ScrollView. On Android, React Native's ScrollView does not propagate testID to the native accessibility tree, so Maestro can no longer find the element. The SafeAreaView (a regular View) did. Wrapping the ScrollView in a plain View that carries the testID restores accessibility-tree visibility without changing the layout (both use styles.container → flex: 1).

This unblocks shard 8 (Android) and 12 other Maestro flows that wait on sidebar-view: profile.yaml, status.yaml, setting.yaml, user-preferences.yaml, change-avatar.yaml, i18n.yaml, e2ee/utils/navigate-to-e2ee-security.yaml, assorted/utils/check-server.yaml, assorted/utils/nav-to-language.yaml, etc.

Profile test rate-limit fix (folded in)

Shard 8 (profile.yaml) was failing on Android even after the sidebar testID fix: the test made three consecutive users.updateOwnBasicInfo calls (name+username, then nickname+bio, then email) within Maestro 2.5.1's faster pacing. The endpoint is rate-limited per-user, so the second or third call returned HTTP 429 and the error alert disrupted the password-confirm sheet that follows the email change.

Collapse the three submits into one combined submit that edits all five fields (name, username, nickname, bio, email) before tapping submit. The email change still triggers the ConfirmEmailChangeActionSheet, so the password sheet → save path is preserved. Result: 3 rate-limited calls → 1 call. The downstream password-change step (ChangePasswordView) is unchanged.

Form keyboard scroll fix — Maestro iOS shard 6 (folded in)

iOS shard 6 (assorted/deeplink.yaml → helpers/create-account.yaml on the alternate server) was failing with the email field corrupted as tmobile+…@rocket.chat or similar leading-character mutations. Maestro logs showed it had typed the correct text; the field state did not match.

Root cause is the keyboard covering the focused field at tap time. FormContainer wraps a plain ScrollView in KeyboardAvoidingView (behavior='padding'), which only pads the bottom inset on keyboard appearance — focused inputs are never scrolled above the keyboard. With each field's onSubmitEditing → setFocus(next) advancing focus through the form, the email input's hit-test centre ended up below the keyboard top edge. Maestro 2.5.1's tapOn then routed to the QWERTY t key, depositing t into the (already-focused) email field before inputText typed the rest. Maestro 2.2.0 didn't expose this because its input mechanism predated keystroke-based typing.

Swap KeyboardAvoidingView + ScrollView for KeyboardAwareScrollView from react-native-keyboard-controller (already a dep). KAS auto-scrolls the focused TextInput above the keyboard on focus change, so every subsequent tapOn lands on a visible target. Verified locally on iPhone 16 Pro iOS 26 with CI sim defaults (UIAnimationDragCoefficient=10): 3/3 reproductions, down from 2/5 failure rate (40%) on the unfixed branch.

Known status — shard 12 (room-last-message-thread-50-plus.yaml) deferred

Tracked as NATIVE-1128. Earlier commits on this branch (fecac89bd, c14d8d0ff) attempted to stabilize shard 12's scrollUntilVisible step; both have been reverted (file matches develop exactly). Investigation against a local emulator showed the failure isn't a timeout, keyboard, or coordinate-bounds issue:

• Identical pixel-coordinate swipes via adb shell input swipe 540 840 540 1800 400 repeatedly load older messages and keep the room view intact.
• The same coordinates via maestro's swipe: start: 50%,35% end: 50%,75% (or scrollUntilVisible direction:UP) cause the room view to exit to the rooms list mid-scroll, then time out searching for message-content-message 1 in a screen where it can't possibly appear.
• Adding hideKeyboard (keyboard re-opens mid-scroll on CI) and gating the scroll on notVisible: "Waiting for network..." did not change the outcome.

Root cause is in maestro's Android gesture injection vs RN's gesture handling, not in the YAML or the app. Tracked for follow-up. CI's per-flow internal rerun continues to recover this shard the same way it has since #6680 landed (see run 25804460186 — Android shard 12 failed first attempt at 2m 51s, passed on rerun in 44s).

Known status — shard 11 (jump-to-message.yaml) deferred

Shard 11 remains chronically red on both Android and iOS, and is not fixed by this PR. Treated as a pre-existing baseline failure per the team's "gate on e2e build success, treat shard pass/fail as informational" policy.

Investigation during this PR surfaced two product regressions in the room view that likely contribute to the Maestro flow failing (the flow exercises both the composer and the quote-attachment tap path):

• NATIVE-1125 — Composer auto-focuses on RoomView open (keyboard pops up immediately).
• NATIVE-1126 — Tapping the quoted message attachment does not navigate to the source message.

Root cause (both regressions and the shard 11 flow itself) is not yet confirmed and is tracked as follow-up work. Shard 11 will be re-enabled once those bugs land their fixes.

Issue(s)

NATIVE-1123

Related (deferred, will not be fixed in this PR):

• NATIVE-1125
• NATIVE-1126
• NATIVE-1128 — maestro gesture injection dismisses RoomView on shard 12

How to test or reproduce

1. Trigger the Build PR workflow on this branch.
2. Watch the 14 Android + 13 iOS Maestro shards.
3. Spot-check shard logs for absence of Broken pipe, meminfo DUMP TIMEOUT, Monkey aborted, and Failed to install apk.
4. For the sidebar fix specifically: maestro --device emulator-5554 hierarchy | grep sidebar-view returns 0 matches on develop and returns the testID on this branch. Shard 8 (profile.yaml) progresses past the sidebar step.
5. For the profile rate-limit fix: shard 8 should reach the password-confirm sheet, save successfully, then continue into ChangePasswordView and finish.
6. For the form-keyboard-scroll fix: iOS shard 6 (DeepLink flow) should reach rooms-list-view after helpers/create-account.yaml without the email field being corrupted (no leading t/tmobile substitution).
7. Compare per-shard pass-rate against recent develop runs (informational here; full 10-run acceptance window is a separate follow-up).
8. Shard 11 (jump-to-message.yaml) is expected to remain red — see deferred-status note above.

Screenshots

n/a

Types of changes

• Bugfix (non-breaking change which fixes an issue) — sidebar testID, profile test rate-limit, form keyboard scroll (shard 6)
• Improvement (non-breaking change which improves a current function) — CI stabilization

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable) — covered by existing Maestro flows that the sidebar fix unblocks; CI infra otherwise
• I have added necessary documentation (if applicable) — inline comments added next to each pinned version
• Any dependent changes have been merged and published in downstream modules

Further comments

Acceptance is measured empirically over a 10-run window on develop after this lands; that measurement is tracked separately.

The sidebar testID fix was originally opened as #7319 and folded in here (#7319 closed) so the CI stabilization and the test-visibility fix it depends on ship together.

Summary by CodeRabbit

• Chores

  • Upgraded Maestro CLI to 2.5.1 for Android and iOS; improved emulator caching and increased emulator memory for Android.
  • Adjusted test workflow retry behavior and added pre-test app install to improve run reliability.

• Tests

  • Consolidated profile edit flow into a single submit and added deterministic scrolling in message-thread tests to reduce flakiness.

• Style

  • Minor Sidebar layout adjustment (no functional change).

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

This PR upgrades Maestro to 2.5.1 (Android/iOS), changes Android AVD caching and emulator RAM/options, replaces the Android monkey pre-test step with adb install -r, adjusts iOS retry behavior to error, batches profile test edits, and moves SidebarView's testID to an outer View.

Changes

Maestro Test Infrastructure Upgrade

Layer / File(s)	Summary
Maestro Version & iOS retry changes .github/workflows/maestro-android.yml, .github/workflows/maestro-ios.yml	MAESTRO_VERSION pinned to 2.5.1 (Android & iOS); iOS “Run Maestro Tests” retry changed from timeout to error.
Android Emulator & AVD Caching Strategy .github/workflows/maestro-android.yml	Gates AVD cache to non-shard-14, boots pixel_7_pro on cache miss to generate a snapshot, increases emulator RAM to 6144M, and adds -no-snapshot-save for non-keyboard runs; shard-14 step also uses 6144M.
Test Execution Script & Maestro Tests .github/scripts/run-maestro.sh, .maestro/tests/assorted/profile.yaml, .maestro/tests/room/room-last-message-thread-50-plus.yaml	Replaces Android monkey-launch/force-stop with adb install -r app-experimental-release.apk before Maestro; Maestro invocation unchanged; profile test batches multiple field edits into a single submit; room test replaces scrollUntilVisible with a deterministic repeat-scroll sequence.

Sidebar View Layout Change

Layer / File(s)	Summary
Imports app/views/SidebarView/index.tsx	Adds View to react-native imports.
Render app/views/SidebarView/index.tsx	Wraps ScrollView in an outer View with testID='sidebar-view'; removes testID from ScrollView.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main objective: upgrading Maestro to version 2.5.1 and increasing emulator memory for CI stability.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (4)

• NATIVE-1125: Request failed with status code 401
• NATIVE-1126: Request failed with status code 401
• NATIVE-1123: Request failed with status code 401
• EMULATOR-5554: Request failed with status code 401

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/maestro-android.yml (1)

41-48: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Shard 14 can poison the shared AVD cache, defeating the snapshot optimization for all other shards

The Cache Android AVD step has no if condition, so shard 14 participates in both cache restore and save under the same key (avd-${{ runner.os }}-api34).

On a cold run, all 14 shards race to save to that key (GitHub Actions is first-writer-wins). If shard 14 wins, the cache stores only Pixel_API_34_Keyboard.avd + Pixel_API_34_Keyboard.ini. On subsequent runs:

1. Non-keyboard shards see steps.avd-cache.outputs.cache-hit == 'true'
2. The "Generate AVD snapshot" step is skipped (its condition checks cache-hit != 'true')
3. The test step runs with force-avd-creation: false — but the expected default-profile AVD is absent from the restored cache

The behavior of reactivecircus/android-emulator-runner when force-avd-creation: false and the named AVD doesn't exist is unspecified; it may silently cold-boot (losing the optimization) or fail outright. Either way, the caching strategy is silently broken.

🐛 Proposed fix — exclude shard 14 from AVD caching

      - name: Cache Android AVD
+       if: ${{ inputs.shard != '14' }}
        id: avd-cache
        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
        with:
          path: |
            ~/.android/avd/*
            ~/.android/adb*
          key: avd-${{ runner.os }}-api34

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/maestro-android.yml around lines 41 - 48, The "Cache
Android AVD" step (id: avd-cache, name: Cache Android AVD, key: avd-${{
runner.os }}-api34) must be excluded from shard 14 so it doesn't poison the
shared AVD cache; update the step to run only when the shard is not 14 (e.g. add
an if condition referencing your matrix/shard variable such as if: matrix.shard
!= 14) so shard 14 neither restores nor saves to the common key, leaving other
shards to generate and cache the full AVD snapshot correctly.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/maestro-android.yml:
- Around line 24-33: The workflow currently uses the jlumbroso/free-disk-space
action with swap-storage: true while configuring the emulator's ram-size: 6144M,
which disables swap and leaves under ~800MB host memory — change either the
swap-storage or ram-size to avoid OOMs: set swap-storage: false to retain the
runner swapfile, or reduce ram-size to 5120M or 4608M so host+emulator fit in
physical RAM; update the keys swap-storage and ram-size in the action usage
(uses: jlumbroso/free-disk-space@...) and apply the same change to the other
occurrences noted (the other blocks referenced) so all workflow entries are
consistent.

In @.github/workflows/maestro-ios.yml:
- Around line 14-15: The comment incorrectly mentions the Android-specific
"dadb"/ADB change; update the comment text that currently references "dadb" and
ADB to an iOS-appropriate note explaining that iOS Maestro uses
idb/libimobiledevice (not ADB) and that the Android-specific CLI 2.5.0 change
does not apply to the iOS workflow; either remove the ADB-specific sentence or
replace it with a short iOS-focused explanation and keep or adjust the release
link as needed so the comment accurately reflects iOS tooling.

---

Outside diff comments:
In @.github/workflows/maestro-android.yml:
- Around line 41-48: The "Cache Android AVD" step (id: avd-cache, name: Cache
Android AVD, key: avd-${{ runner.os }}-api34) must be excluded from shard 14 so
it doesn't poison the shared AVD cache; update the step to run only when the
shard is not 14 (e.g. add an if condition referencing your matrix/shard variable
such as if: matrix.shard != 14) so shard 14 neither restores nor saves to the
common key, leaving other shards to generate and cache the full AVD snapshot
correctly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee299d9c-ce31-45fd-89b1-673983985558

📥 Commits

Reviewing files that changed from the base of the PR and between 8b70425 and 5ee7fad.

📒 Files selected for processing (3)

• .github/scripts/run-maestro.sh
• .github/workflows/maestro-android.yml
• .github/workflows/maestro-ios.yml

💤 Files with no reviewable changes (1)

• .github/scripts/run-maestro.sh

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: E2E Build Android / android-build
• GitHub Check: ESLint and Test / run-eslint-and-test

[github-actions]

Android Build Available

Rocket.Chat 4.72.0.108814

[github-actions]

Android Build Available

Rocket.Chat 4.72.0.108814

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNRwjAsJvaiquGjKRmucVItIwkqzqmtF75VX3MLDxOhuznxMA2GxetWxp_dAfRbh33wL0-dHZMTeQVHqchi7

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.72.0.108813

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.72.0.108813

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTowuRjjHlDYUgXqroMl8epJWmBJOAe-7N_6W5JjAcJyBHu-MfbZDIilMfFnPJkwzs7kKMzme1NVFTUUxnE

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.72.0.108816

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.72.0.108821

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQLTMEQOTK7Yu4n98ufM0ImDLGPoEI7tdqqt4_8PqA3XXsk_0JhIS1tJIiRPRZJU0Eh3mtvcPjDUgnnZ0rq

[github-actions]

Android Build Available

Rocket.Chat 4.72.0.108820

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQrTqib34jYoZve6A-78lxC3zI5hjF5NuHRtFdGLOxp7tcQ3xwQyvjeTqlI5Lq2c3nCQqQiv5zaR2Rc0VBd

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.72.0.108822

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.73.0.108867

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTnzfDm_AHURT9Pw2SncEbPOaRNvLiEXkhsX2mzyk3VI0uTIlNGSEvB0mfJlKEpMmMk1MBQ45cY2PHUWiYs

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.73.0.108869