Skip to content

Fix to MS History table reader - #1596

Merged
bhazelton merged 1 commit into
mainfrom
ms_history_fix
Jul 16, 2025
Merged

Fix to MS History table reader#1596
bhazelton merged 1 commit into
mainfrom
ms_history_fix

Conversation

@kartographer

Copy link
Copy Markdown
Contributor

Description

Changes utils.io.ms.read_ms_history to handle when the "APP_PARAMS" and "CLI_COMMAND" are populated in a non-standard way (either unpopulated or populated with an empty array).

Motivation and Context

The original motivation for this was fixing a bug when reading in LOFAR1 files, although I realized that actually the way that we were handling weirdness in the "APP_PARAMS" and "CLI_COMMAND" columns was actually making it so that the history wasn't being round-tripped correctly, so I've modified things to resolve both issues.

Closes #1587

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • I have updated the CHANGELOG.

@codecov

codecov Bot commented Jul 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (9bdd3c0) to head (2942834).
⚠️ Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   99.93%   99.93%   -0.01%     
==========================================
  Files          63       63              
  Lines       22304    22298       -6     
==========================================
- Hits        22289    22283       -6     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhazelton
bhazelton merged commit 1f3c6b7 into main Jul 16, 2025
48 checks passed
@bhazelton
bhazelton deleted the ms_history_fix branch July 16, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyuvdata.utils.io.ms.read_ms_history IndexError for empty column

2 participants