Skip to content

Fix a bug in the UVBeam yaml constructor - #1594

Merged
steven-murray merged 1 commit into
mainfrom
fix_uvbeam_constructor
Jul 17, 2025
Merged

Fix a bug in the UVBeam yaml constructor#1594
steven-murray merged 1 commit into
mainfrom
fix_uvbeam_constructor

Conversation

@bhazelton

@bhazelton bhazelton commented Jul 15, 2025

Copy link
Copy Markdown
Member

Description

This fixes a bug discovered by @wps2n where the freq_range was ignored by the UVBeam yaml constructor because the yaml mapping wasn't fully parsed. It turns out that the deep=True parameter must be passed for full parsing, something I discovered earlier for the AnalyticBeam constructor but failed to propagate the fix to the UVBeam constructor. I don't really understand why the default is not to do deep mapping...

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • I have updated the CHANGELOG.

@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (1f3c6b7) to head (0bc6f7e).
⚠️ Report is 111 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          63       63           
  Lines       22298    22300    +2     
=======================================
+ Hits        22283    22285    +2     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

steven-murray
steven-murray previously approved these changes Jul 17, 2025

@steven-murray steven-murray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a weird default!

@bhazelton

Copy link
Copy Markdown
Member Author

@steven-murray I had to rebase this, can you please reapprove?

@steven-murray
steven-murray merged commit cb5c607 into main Jul 17, 2025
48 checks passed
@steven-murray
steven-murray deleted the fix_uvbeam_constructor branch July 17, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants