Fix a bug in the UVBeam yaml constructor - #1594
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 63 63
Lines 22298 22300 +2
=======================================
+ Hits 22283 22285 +2
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
steven-murray
previously approved these changes
Jul 17, 2025
steven-murray
left a comment
Contributor
There was a problem hiding this comment.
What a weird default!
bhazelton
force-pushed
the
fix_uvbeam_constructor
branch
from
July 17, 2025 17:22
656c078 to
0bc6f7e
Compare
Member
Author
|
@steven-murray I had to rebase this, can you please reapprove? |
steven-murray
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug discovered by @wps2n where the
freq_rangewas ignored by the UVBeam yaml constructor because the yaml mapping wasn't fully parsed. It turns out that thedeep=Trueparameter must be passed for full parsing, something I discovered earlier for the AnalyticBeam constructor but failed to propagate the fix to the UVBeam constructor. I don't really understand why the default is not to do deep mapping...Motivation and Context
Types of changes
Checklist:
Bug fix checklist: