Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the RCCL Linux CMake toolchain by making ROCm path and compiler detection more robust and by tweaking default debug flag behavior for “DebugFast” vs regular Debug.
Changes:
- Add explicit ROCm path detection precedence (
-DROCM_PATH>$ROCM_PATH>/opt/rocm) and fail fast if the path doesn’t exist. - Add compiler auto-detection fallbacks under
${ROCM_PATH}/binand${ROCM_PATH}/llvm/bin, respecting-DCMAKE_{C,CXX}_COMPILERand$CC/$CXX. - Adjust default Debug flags to differentiate “DebugFast” from normal Debug.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alex-breslow-amd
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve
toolchain-linux.cmakerobustnessTechnical Details
-DROCM_PATHcmake flag andROCM_PATHenv. flag.PATHenv./opt/rocmas fallback.JIRA ID
Test Plan
Test Result
Submission Checklist