[rocprofiler-compute] Add backward compatible live attach support for ROCm 7.2 by vedithal-amd · Pull Request #4929 · ROCm/rocm-systems

vedithal-amd · 2026-04-10T22:22:13Z

Motivation

Live attach profiling (--attach-pid) fails on ROCm 7.2 where librocprofiler-sdk-rocattach.so is not available. Add library resolution fallback and prefer the newer API while retaining backward compatibility.

Technical Details

Add fallback from librocprofiler-sdk-rocattach.so to librocprofv3-attach.so when the new library is not available
Fail early with a clear error if no live attach library is found
Invert API call order in perform_attach_detach() to try new API (rocattach_attach/rocattach_detach) first, falling back to old API (attach/detach)

JIRA ID

Test Plan

Run rocprof-compute profile --attach-pid <PID> on a system with librocprofiler-sdk-rocattach.so (new library) and verify it uses the new API
Run rocprof-compute profile --attach-pid <PID> on a system with only librocprofv3-attach.so (old library) and verify it falls back correctly

Test Result

Manual tests have passed.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

… older ROCm - Add fallback from librocprofiler-sdk-rocattach.so to librocprofv3-attach.so when the new library is not available - Fail early with a clear error if no live attach library is found - Invert API call order to try new API (rocattach_attach/rocattach_detach) first, falling back to old API (attach/detach) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feizheng10

Do we need update changlog for this?

Copilot

Pull request overview

Adds backward-compatible live attach support for ROCm 7.2 by resolving the attach library with a fallback to the older attach library, and preferring the newer rocattach API while retaining the legacy attach/detach API path.

Changes:

Add attach-library resolution fallback: librocprofiler-sdk-rocattach.so → librocprofv3-attach.so, with early error if neither exists.
Invert live attach call order to try rocattach_attach/rocattach_detach first, then fall back to attach/detach.
Improve logging for live attach API selection by adding console_debug usage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
projects/rocprofiler-compute/src/utils/utils_common.py	Prefer new rocattach API for live attach/detach with fallback to legacy API.
projects/rocprofiler-compute/src/rocprof_compute_profile/profiler_rocprofiler_sdk.py	Add attach library resolution fallback for ROCm 7.2 installs missing the new rocattach library.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-10T22:28:10Z

+                # old live attach API
+                c_lib.attach.argtypes = [ctypes.c_uint]


In the old live attach API fallback you only set c_lib.attach.argtypes, but later you call c_lib.detach(int(pid)) as well. For ctypes calls, leaving detach (and attach’s restype) untyped can lead to incorrect argument/return conversions and makes the two call paths inconsistent. Please set c_lib.detach.argtypes (and consider restype) alongside attach when using the old API.

Suggested change

# old live attach API

c_lib.attach.argtypes = [ctypes.c_uint]

# old live attach API

c_lib.attach.restype = ctypes.c_int

c_lib.attach.argtypes = [ctypes.c_uint]

c_lib.detach.restype = ctypes.c_int

c_lib.detach.argtypes = [ctypes.c_uint]

Copilot · 2026-04-10T22:28:10Z

        pid = options["ROCPROF_ATTACH_PID"]
        if pid is None:
-            console_error("Mode of attach/detach must have setup for process ID")
+            console_error("Mode of live attach must have setup for process ID")


The error text is grammatically unclear: "Mode of live attach must have setup for process ID". Consider rephrasing to something like "Live attach mode requires a process ID (ROCPROF_ATTACH_PID)" so users immediately know what to set.

Suggested change

console_error("Mode of live attach must have setup for process ID")

console_error(

"Live attach mode requires a process ID (ROCPROF_ATTACH_PID)"

)

Copilot · 2026-04-10T22:28:11Z

            rocprofiler_attach_library_path = resolve_rocm_library_path(
                str(
                    Path(args.rocprofiler_sdk_tool_path).parent.parent
                    / "librocprofiler-sdk-rocattach.so"
                )
            )
+            if not Path(rocprofiler_attach_library_path).exists():
+                console_debug(
+                    "New live attach library not found, trying old live attach library"
+                )
+                rocprofiler_attach_library_path = resolve_rocm_library_path(
+                    str(
+                        Path(args.rocprofiler_sdk_tool_path).parent
+                        / "librocprofv3-attach.so"
+                    )
+                )
+            if not Path(rocprofiler_attach_library_path).exists():
+                console_error("No live attach library found.")


The failure message "No live attach library found." doesn’t say which paths were tried, which makes diagnosing packaging/layout issues harder. Consider including the resolved candidate paths (new and old) and/or hinting that --rocprofiler-sdk-tool-path / ROCM_PATH controls the search base.

Suggested change

rocprofiler_attach_library_path = resolve_rocm_library_path(

str(

Path(args.rocprofiler_sdk_tool_path).parent.parent

/ "librocprofiler-sdk-rocattach.so"

)

)

if not Path(rocprofiler_attach_library_path).exists():

console_debug(

"New live attach library not found, trying old live attach library"

)

rocprofiler_attach_library_path = resolve_rocm_library_path(

str(

Path(args.rocprofiler_sdk_tool_path).parent

/ "librocprofv3-attach.so"

)

)

if not Path(rocprofiler_attach_library_path).exists():

console_error("No live attach library found.")

new_attach_library_path = resolve_rocm_library_path(

str(

Path(args.rocprofiler_sdk_tool_path).parent.parent

/ "librocprofiler-sdk-rocattach.so"

)

)

old_attach_library_path = resolve_rocm_library_path(

str(

Path(args.rocprofiler_sdk_tool_path).parent

/ "librocprofv3-attach.so"

)

)

rocprofiler_attach_library_path = new_attach_library_path

if not Path(rocprofiler_attach_library_path).exists():

console_debug(

"New live attach library not found, trying old live attach library"

)

rocprofiler_attach_library_path = old_attach_library_path

if not Path(rocprofiler_attach_library_path).exists():

console_error(

"No live attach library found. Tried resolved paths: "

f"new='{new_attach_library_path}', "

f"old='{old_attach_library_path}'. "

"Check --rocprofiler-sdk-tool-path and/or ROCM_PATH."

)

Copilot · 2026-04-10T22:28:11Z

+            # Try new live attach library first, fall back to old library
            rocprofiler_attach_library_path = resolve_rocm_library_path(
                str(
                    Path(args.rocprofiler_sdk_tool_path).parent.parent
                    / "librocprofiler-sdk-rocattach.so"
                )
            )
+            if not Path(rocprofiler_attach_library_path).exists():
+                console_debug(
+                    "New live attach library not found, trying old live attach library"
+                )
+                rocprofiler_attach_library_path = resolve_rocm_library_path(
+                    str(
+                        Path(args.rocprofiler_sdk_tool_path).parent
+                        / "librocprofv3-attach.so"
+                    )
+                )
+            if not Path(rocprofiler_attach_library_path).exists():
+                console_error("No live attach library found.")


This adds important fallback behavior (new attach library -> old attach library) but there’s no unit test coverage validating the selection logic (e.g., new missing/old present, both missing => error). Since get_profiler_options() already has unit tests in this repo, please add a focused test that mocks Path.exists()/resolve_rocm_library_path() to exercise these branches.

cfallows-amd · 2026-04-10T22:29:00Z

            )
+            if not Path(rocprofiler_attach_library_path).exists():
+                console_debug(
+                    "New live attach library not found, trying old live attach library"


Suggested change

"New live attach library not found, trying old live attach library"

"Latest live attach library not found, searching for legacy live attach library"

Replacement of word "new" to not mislead users if this comment does not change any time soon and "new" is not really..."new" anymore. Also word swap for old -> legacy, optional substitution.

cfallows-amd · 2026-04-10T22:31:33Z

            console_debug(
-                "Error setting old attach/detach API argument "
-                f"types: {e}, trying new API"
+                f"Error setting new live attach API argument types: {e}, trying old API"


Suggested change

f"Error setting new live attach API argument types: {e}, trying old API"

f"Error setting new live attach API argument types: {e}, trying legacy live attach API"

cfallows-amd · 2026-04-10T22:32:27Z

+                )
        except Exception as e:
-            console_debug(f"Error attaching with old API: {e}, trying new API")
+            console_debug(f"Error attaching with new API: {e}, trying old API")


Suggested change

console_debug(f"Error attaching with new API: {e}, trying old API")

console_debug(f"Error attaching with latest live attach API: {e}, trying legacy live attach API")

cfallows-amd · 2026-04-10T22:33:33Z

+                )
        except Exception as e:
-            console_debug(f"Error detaching with old API: {e}, trying new API")
+            console_debug(f"Error detaching with new API: {e}, trying old API")


Suggested change

console_debug(f"Error detaching with new API: {e}, trying old API")

console_debug(f"Error detaching with latest live attach API: {e}, trying detach with legacy live attach API")

vedithal-amd requested a review from a team as a code owner April 10, 2026 22:22

Copilot AI review requested due to automatic review settings April 10, 2026 22:22

github-actions bot added the project: rocprofiler-compute label Apr 10, 2026

Copilot started reviewing on behalf of vedithal-amd April 10, 2026 22:24 View session

feizheng10 approved these changes Apr 10, 2026

View reviewed changes

Copilot AI reviewed Apr 10, 2026

View reviewed changes

cfallows-amd reviewed Apr 10, 2026

View reviewed changes

systems-assistant bot added the organization: ROCm label Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rocprofiler-compute] Add backward compatible live attach support for ROCm 7.2#4929

[rocprofiler-compute] Add backward compatible live attach support for ROCm 7.2#4929
vedithal-amd wants to merge 1 commit intodevelopfrom
users/vedithal-amd/rocprofiler-compute-fix-attach

vedithal-amd commented Apr 10, 2026

Uh oh!

feizheng10 left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

cfallows-amd Apr 10, 2026

Uh oh!

cfallows-amd Apr 10, 2026

Uh oh!

cfallows-amd Apr 10, 2026

Uh oh!

cfallows-amd Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		# old live attach API
		c_lib.attach.argtypes = [ctypes.c_uint]

	"New live attach library not found, trying old live attach library"
	"Latest live attach library not found, searching for legacy live attach library"

	f"Error setting new live attach API argument types: {e}, trying old API"
	f"Error setting new live attach API argument types: {e}, trying legacy live attach API"

	console_debug(f"Error attaching with new API: {e}, trying old API")
	console_debug(f"Error attaching with latest live attach API: {e}, trying legacy live attach API")

	console_debug(f"Error detaching with new API: {e}, trying old API")
	console_debug(f"Error detaching with latest live attach API: {e}, trying detach with legacy live attach API")

Conversation

vedithal-amd commented Apr 10, 2026

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

Uh oh!

feizheng10 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

cfallows-amd Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

cfallows-amd Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

cfallows-amd Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

cfallows-amd Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants