Partially revert c76140fa277895b3886cf1780a36fe504a1aac3a: revert amdsmi-related cmake changes only#4923
Open
araravik-psd wants to merge 1 commit intodevelopfrom
Open
Partially revert c76140fa277895b3886cf1780a36fe504a1aac3a: revert amdsmi-related cmake changes only#4923araravik-psd wants to merge 1 commit intodevelopfrom
araravik-psd wants to merge 1 commit intodevelopfrom
Conversation
wenkaidu
requested changes
Apr 10, 2026
|
|
||
| // Enable use of amd_smi_lib instead of internal ARSMI code by default; set RCCL_USE_AMD_SMI_LIB=1 to enable amd_smi_lib and use the AMD SMI path | ||
| RCCL_PARAM(UseAmdSmiLib, "USE_AMD_SMI_LIB", AMDSMI_DEFAULT_ENABLED); |
Contributor
There was a problem hiding this comment.
This needs to be set to disabled by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to partially land back reverted changes in c76140f other than the amdsmi cmake changes which were landed as part of the PR.
The Primary revert #4802 was originally applied to get Pytorch builds back to green as explained in #4802 description.
Adding back changes for thread-safety and wrapper usage as requested in the issue comment #4802 (comment)
These changes were tested with a submodule bump in TheRock:
Passing Pytorch builds:
https://github.com/ROCm/TheRock/actions/runs/24211884393
https://github.com/ROCm/TheRock/actions/runs/24208190701