Conversation
Does this exclude the documentation team reviewers? |
There was a problem hiding this comment.
Pull request overview
Adds an automated PR review-status dashboard for ROCm/AMDMIGraphX intended to be published via GitHub Pages, grouping open non-draft PRs by reviewer/approval/CI status and supporting “#dash_note” annotations.
Changes:
- Added a Python data generator that queries GitHub APIs and emits a categorized JSON report.
- Added a static HTML dashboard that renders
data.jsoninto summary cards and bucket tables. - Added a GitHub Actions workflow intended to generate
data.jsonhourly and deploy the dashboard to GitHub Pages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tools/pr-review-status.py |
Collects PR/review/CI/comment data and outputs a structured JSON report for the dashboard. |
pr_review_dashboard/index.html |
Renders the JSON report into a GitHub Pages-friendly dashboard UI. |
.github/pr-review-status.yaml |
Intended scheduled/manual Pages deploy workflow to refresh and publish the dashboard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - run: pip install requests | ||
|
|
||
| - name: Generate data.json | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }} | ||
| run: python tools/pr-review-status.py --json > pr_review_dashboard/data.json | ||
|
|
There was a problem hiding this comment.
This workflow relies on a long-lived PAT stored in secrets.PAT_TOKEN to query PR/review data. For least-privilege and easier rotation, prefer using the built-in GITHUB_TOKEN (and add the minimal required permissions: such as pull-requests: read) or a GitHub App / fine-grained token scoped to read-only repo/PR metadata.
There was a problem hiding this comment.
It needs PAT because the GITHUB_TOKEN doesn't have enough access. We can do a fine-grained token, but it would have to be from the ROCm user who owns the AMDMIGraphX repo
It should exclude them if they do not have push/write access to the repo. If they do have access we would have to maintain a list of valid reviewers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4779 +/- ##
===========================================
+ Coverage 92.45% 92.49% +0.04%
===========================================
Files 583 583
Lines 29298 29515 +217
===========================================
+ Hits 27085 27297 +212
- Misses 2213 2218 +5 🚀 New features to boost your workflow:
|
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable