fix: avoid double resize when fetch_video receives image list#2045
Open
HT-Yuan wants to merge 1 commit intoQwenLM:mainfrom
Open
fix: avoid double resize when fetch_video receives image list#2045HT-Yuan wants to merge 1 commit intoQwenLM:mainfrom
HT-Yuan wants to merge 1 commit intoQwenLM:mainfrom
Conversation
6 tasks
Author
|
@ShuaiBai623 Can we merge this MR? We believe it will help improve the inference speed of Qwen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: avoid double resize when fetch_video receives image list
What's changed
Extract
load_imagefromfetch_image()to handle image loading and RGB conversion without resizing.In
fetch_video's image list branch, useload_image()instead offetch_image()so that images are only resized once (at VIDEO level with dynamicmax_pixelscap).What's fixed
Avoid the previous double resize that caused:
Fixes #1833