Skip to content

Add tag indicators, entanglement links, and message buffer tooltips#332

Closed
nenadilic84 wants to merge 2 commits intoQuantumSavory:masterfrom
nenadilic84:makie-tag-visualization
Closed

Add tag indicators, entanglement links, and message buffer tooltips#332
nenadilic84 wants to merge 2 commits intoQuantumSavory:masterfrom
nenadilic84:makie-tag-visualization

Conversation

@nenadilic84
Copy link
Copy Markdown

Addresses #66 and #96, as part of the scope proposed for #132.

Changes

Tag visualization on plots (#66)

  • Tag indicator markers: Small triangle markers (:utriangle, royal blue) appear on slots that have tags, providing at-a-glance indication without needing to hover. Configurable via tag_marker, tag_markersize, tag_markercolor theme options.

  • Entanglement links: Dashed lines connect slots with EntanglementCounterpart tags, visualizing non-local entanglement relationships across the network. Duplicate links are avoided via canonical pair ordering. Configurable via entanglement_linecolor, entanglement_linewidth theme options.

Message buffer in tooltips (#96)

  • Slot hover tooltips now show the register's message buffer contents (up to 5 most recent messages) when available, accessed via the register's netparent and cbuffers.

Implementation details

  • Both features integrate with the existing update_plot observable/notify infrastructure and update reactively
  • Entanglement links are drawn early in the z-order (behind slot markers) for visual clarity
  • Tag indicators are drawn on top of locks for visibility
  • New observables (tag_indicator_coords, entanglement_link_coords) are properly emptied and notified in the update cycle

Test plan

  • New test cases in test_plotting_2_tags_observables.jl cover:
    • Tag indicator markers on tagged slots
    • Entanglement link visualization between EntanglementCounterpart-tagged slots
    • Message buffer tooltip rendering with put! messages
    • Custom theme options for all new visual elements

…o RegisterNetPlot

Addresses issues QuantumSavory#66 and QuantumSavory#96:

Tag visualization on plots (QuantumSavory#66):
- Small triangle markers on slots that have tags, providing at-a-glance
  indication of tagged slots without needing to hover
- Dashed lines connecting slots with EntanglementCounterpart tags,
  visualizing non-local entanglement relationships across the network
- New theme options: tag_marker, tag_markersize, tag_markercolor,
  entanglement_linecolor, entanglement_linewidth

Message buffer in tooltips (QuantumSavory#96):
- Slot hover tooltips now show the register's message buffer contents
  (up to 5 most recent messages) when available

Both features update reactively via the existing observable/notify
infrastructure and are covered by new test cases.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2026

Benchmark Results (Julia v1)

Time benchmarks
master af67876... master / af67876...
onchange/dual_messagebuffer_any/writers_2_waiters_1 1.27 ± 0.032 ms 1.29 ± 0.034 ms 0.981 ± 0.036
onchange/dual_messagebuffer_any/writers_4_waiters_1 2.51 ± 0.075 ms 2.55 ± 0.074 ms 0.984 ± 0.041
onchange/dual_messagebuffer_any/writers_4_waiters_4 2.05 ± 0.052 ms 2.06 ± 0.06 ms 0.998 ± 0.038
onchange/dual_messagebuffer_any/writers_8_waiters_4 4.08 ± 0.22 ms 4.1 ± 0.24 ms 0.996 ± 0.079
onchange/sharded_registers/pairs_1 0.682 ± 0.092 ms 0.722 ± 0.087 ms 0.944 ± 0.17
onchange/sharded_registers/pairs_16 10.4 ± 0.15 ms 11.1 ± 0.18 ms 0.942 ± 0.021
onchange/sharded_registers/pairs_32 21.2 ± 0.29 ms 22.5 ± 0.31 ms 0.942 ± 0.018
onchange/sharded_registers/pairs_4 2.55 ± 0.046 ms 2.72 ± 0.052 ms 0.936 ± 0.025
onchange/shared_messagebuffer_channel/writers_1_waiters_1 0.881 ± 0.022 ms 0.909 ± 0.022 ms 0.969 ± 0.034
onchange/shared_messagebuffer_channel/writers_1_waiters_8 0.567 ± 0.023 ms 0.597 ± 0.021 ms 0.949 ± 0.05
onchange/shared_messagebuffer_channel/writers_4_waiters_4 2.33 ± 0.3 ms 2.45 ± 0.31 ms 0.951 ± 0.17
onchange/shared_messagebuffer_channel/writers_8_waiters_1 6.92 ± 0.77 ms 7.1 ± 0.82 ms 0.975 ± 0.16
onchange/shared_messagebuffer_direct/writers_16_waiters_2 5.18 ± 0.86 ms 5.33 ± 0.95 ms 0.973 ± 0.24
onchange/shared_messagebuffer_direct/writers_1_waiters_1 0.425 ± 0.063 ms 0.444 ± 0.068 ms 0.956 ± 0.2
onchange/shared_messagebuffer_direct/writers_1_waiters_8 0.297 ± 0.056 ms 0.298 ± 0.061 ms 0.995 ± 0.28
onchange/shared_messagebuffer_direct/writers_2_waiters_16 0.527 ± 0.099 ms 0.525 ± 0.11 ms 1 ± 0.28
onchange/shared_messagebuffer_direct/writers_4_waiters_4 1.12 ± 0.2 ms 1.13 ± 0.22 ms 0.985 ± 0.26
onchange/shared_messagebuffer_direct/writers_8_waiters_1 3.07 ± 0.46 ms 3.3 ± 0.52 ms 0.932 ± 0.2
onchange/shared_register/writers_16_waiters_2 9.69 ± 1.5 ms 10.2 ± 1.5 ms 0.949 ± 0.2
onchange/shared_register/writers_1_waiters_1 0.688 ± 0.092 ms 0.751 ± 0.082 ms 0.917 ± 0.16
onchange/shared_register/writers_1_waiters_8 0.682 ± 0.11 ms 0.677 ± 0.12 ms 1.01 ± 0.24
onchange/shared_register/writers_2_waiters_16 1.74 ± 0.33 ms 1.66 ± 0.36 ms 1.05 ± 0.3
onchange/shared_register/writers_4_waiters_4 2.4 ± 0.36 ms 2.41 ± 0.41 ms 0.997 ± 0.23
onchange/shared_register/writers_8_waiters_1 5.33 ± 0.72 ms 5.82 ± 0.63 ms 0.916 ± 0.16
onchange/shared_regref/writers_1_waiters_1 0.707 ± 0.088 ms 0.752 ± 0.084 ms 0.94 ± 0.16
onchange/shared_regref/writers_1_waiters_8 0.684 ± 0.11 ms 0.674 ± 0.12 ms 1.02 ± 0.24
onchange/shared_regref/writers_4_waiters_4 2.41 ± 0.38 ms 2.4 ± 0.39 ms 1 ± 0.23
onchange/shared_regref/writers_8_waiters_1 5.39 ± 0.68 ms 5.76 ± 0.67 ms 0.935 ± 0.16
quantumstates/observable/quantumoptics 0.871 ± 0.25 μs 0.862 ± 0.25 μs 1.01 ± 0.41
querywait/messagebuffer_channel/writers_1_waiters_1 1.05 ± 0.023 ms 1.1 ± 0.024 ms 0.955 ± 0.03
querywait/messagebuffer_channel/writers_1_waiters_8 2.04 ± 0.16 ms 2.06 ± 0.16 ms 0.991 ± 0.11
querywait/messagebuffer_channel/writers_4_waiters_4 6.78 ± 0.9 ms 6.89 ± 0.96 ms 0.983 ± 0.19
querywait/messagebuffer_channel/writers_8_waiters_1 8.42 ± 0.88 ms 8.81 ± 0.88 ms 0.956 ± 0.14
querywait/messagebuffer_direct/writers_1_waiters_1 0.534 ± 0.075 ms 0.602 ± 0.075 ms 0.888 ± 0.17
querywait/messagebuffer_direct/writers_1_waiters_8 1.49 ± 0.23 ms 1.53 ± 0.26 ms 0.97 ± 0.22
querywait/messagebuffer_direct/writers_4_waiters_4 4.44 ± 0.69 ms 4.69 ± 0.8 ms 0.947 ± 0.22
querywait/messagebuffer_direct/writers_8_waiters_1 4.19 ± 0.54 ms 4.64 ± 0.59 ms 0.904 ± 0.16
querywait/register_query_wait/writers_1_waiters_1 0.617 ± 0.072 ms 0.606 ± 0.068 ms 1.02 ± 0.16
querywait/register_query_wait/writers_1_waiters_8 1.65 ± 0.26 ms 1.72 ± 0.26 ms 0.962 ± 0.21
querywait/register_query_wait/writers_4_waiters_4 4.38 ± 0.67 ms 4.46 ± 0.62 ms 0.982 ± 0.2
querywait/register_query_wait/writers_8_waiters_1 4.91 ± 0.59 ms 4.83 ± 0.54 ms 1.02 ± 0.17
querywait/register_querydelete_wait/writers_1_waiters_1 0.599 ± 0.07 ms 0.644 ± 0.066 ms 0.929 ± 0.14
querywait/register_querydelete_wait/writers_1_waiters_8 1.65 ± 0.26 ms 1.74 ± 0.25 ms 0.945 ± 0.2
querywait/register_querydelete_wait/writers_4_waiters_4 4.28 ± 0.63 ms 4.58 ± 0.66 ms 0.933 ± 0.19
querywait/register_querydelete_wait/writers_8_waiters_1 4.84 ± 0.55 ms 5.1 ± 0.52 ms 0.948 ± 0.15
register/creation_and_initialization/from_tests 0.258 ± 0.022 ms 0.269 ± 0.025 ms 0.959 ± 0.12
tagquery/messagebuffer/query 0.472 ± 0.01 μs 1.51 ± 0.04 μs 0.312 ± 0.011
tagquery/messagebuffer/query_high_arity 0.451 ± 0.01 μs 1.42 ± 0.03 μs 0.317 ± 0.0097
tagquery/messagebuffer/query_high_arity_predicate 9.03 ± 2 μs 10.1 ± 2.1 μs 0.893 ± 0.27
tagquery/messagebuffer/query_miss 0.171 ± 0.01 μs 0.17 ± 0.01 μs 1.01 ± 0.083
tagquery/messagebuffer/query_tag_dispatch 1.33 ± 0.01 μs 2.35 ± 0.05 μs 0.566 ± 0.013
tagquery/messagebuffer/querydelete 1.2 ± 0.13 μs 3.39 ± 0.16 μs 0.355 ± 0.042
tagquery/messagebuffer/querydelete_back 0.491 ± 0.13 μs 0.391 ± 0.071 μs 1.26 ± 0.41
tagquery/messagebuffer/querydelete_front 0.221 ± 0.03 μs 0.17 ± 0.021 μs 1.3 ± 0.24
tagquery/messagebuffer/querydelete_miss 0.471 ± 0.11 μs 0.401 ± 0.05 μs 1.17 ± 0.31
tagquery/misc/from_tests 12.4 ± 3.8 μs 9.63 ± 0.62 μs 1.29 ± 0.4
tagquery/register/query 4.89 ± 0.026 s 4.83 ± 0.0055 s 1.01 ± 0.0056
tagquery/register/query_assigned 1.39 ± 0.04 μs 1.03 ± 0.02 μs 1.35 ± 0.047
tagquery/register/query_exact_fifo 0.631 ± 0.03 μs 0.672 ± 0.011 μs 0.939 ± 0.047
tagquery/register/query_exact_filo 2.33 ± 0.03 μs 2.29 ± 0.03 μs 1.02 ± 0.019
tagquery/register/query_locked 1.87 ± 0.08 μs 0.681 ± 0.02 μs 2.75 ± 0.14
tagquery/register/query_miss 2.01 ± 0.011 μs 2.24 ± 0.02 μs 0.898 ± 0.0094
tagquery/register/query_predicate 2.67 ± 0.14 μs 1.5 ± 0.021 μs 1.77 ± 0.096
tagquery/register/query_tag_dispatch 2.11 ± 0.02 μs 2.09 ± 0.02 μs 1.01 ± 0.014
tagquery/register/query_unassigned 1.83 ± 0.041 μs 1.46 ± 0.02 μs 1.25 ± 0.033
tagquery/register/queryall 5.12 s 5.14 s 0.995
tagquery/register/queryall_fifo 3.31 ± 1.8 μs 4.49 ± 0.54 μs 0.736 ± 0.42
tagquery/register/queryall_filo 2.79 ± 0.23 μs 2.72 ± 0.21 μs 1.03 ± 0.12
tagquery/register/queryall_tag_dispatch 2.18 ± 0.021 μs 2.17 ± 0.02 μs 1 ± 0.013
tagquery/register_high_arity/query_exact 0.381 ± 0.02 μs 0.36 ± 0.02 μs 1.06 ± 0.081
tagquery/register_high_arity/query_predicate 1.89 ± 0.05 μs 1.62 ± 0.021 μs 1.17 ± 0.034
tagquery/register_high_arity/queryall 0.381 ± 0.021 μs 0.39 ± 0.02 μs 0.977 ± 0.074
tagquery/register_mutating/querydelete_register 1.82 ± 0.12 μs 1.46 ± 0.12 μs 1.25 ± 0.13
tagquery/register_mutating/querydelete_regref_fifo 1.61 ± 0.12 μs 2.21 ± 0.14 μs 0.729 ± 0.071
tagquery/register_mutating/querydelete_regref_filo 1.47 ± 0.11 μs 1.81 ± 0.13 μs 0.812 ± 0.084
tagquery/register_mutating/untag_by_id 0.251 ± 0.04 μs 0.271 ± 0.031 μs 0.926 ± 0.18
tagquery/register_ref/query_fifo 0.612 ± 0.019 μs 0.781 ± 0.02 μs 0.784 ± 0.032
tagquery/register_ref/query_filo 0.661 ± 0.021 μs 0.741 ± 0.02 μs 0.892 ± 0.037
tagquery/register_ref/query_tag_dispatch 0.401 ± 0.01 μs 0.411 ± 0.011 μs 0.976 ± 0.036
tagquery/register_ref/queryall_fifo 1.03 ± 0.05 μs 1.04 ± 0.03 μs 0.99 ± 0.056
tagquery/register_ref/queryall_filo 0.732 ± 0.03 μs 0.742 ± 0.021 μs 0.987 ± 0.049
time_to_load 18 ± 0.036 s 18 ± 0.05 s 1 ± 0.0034
Memory benchmarks
master af67876... master / af67876...
onchange/dual_messagebuffer_any/writers_2_waiters_1 10.8 k allocs: 0.591 MB 10.8 k allocs: 0.591 MB 1
onchange/dual_messagebuffer_any/writers_4_waiters_1 21.4 k allocs: 1.18 MB 21.4 k allocs: 1.18 MB 1
onchange/dual_messagebuffer_any/writers_4_waiters_4 21.5 k allocs: 1.18 MB 21.5 k allocs: 1.18 MB 1
onchange/dual_messagebuffer_any/writers_8_waiters_4 0.045 M allocs: 2.39 MB 0.045 M allocs: 2.39 MB 1
onchange/sharded_registers/pairs_1 3.85 k allocs: 0.189 MB 3.85 k allocs: 0.189 MB 1
onchange/sharded_registers/pairs_16 0.0692 M allocs: 3.19 MB 0.0692 M allocs: 3.19 MB 1
onchange/sharded_registers/pairs_32 0.143 M allocs: 6.44 MB 0.143 M allocs: 6.44 MB 1
onchange/sharded_registers/pairs_4 15.6 k allocs: 0.768 MB 15.6 k allocs: 0.768 MB 1
onchange/shared_messagebuffer_channel/writers_1_waiters_1 4.67 k allocs: 0.241 MB 4.67 k allocs: 0.241 MB 1
onchange/shared_messagebuffer_channel/writers_1_waiters_8 4.68 k allocs: 0.241 MB 4.68 k allocs: 0.241 MB 1
onchange/shared_messagebuffer_channel/writers_4_waiters_4 18.4 k allocs: 0.949 MB 18.4 k allocs: 0.949 MB 1
onchange/shared_messagebuffer_channel/writers_8_waiters_1 0.0384 M allocs: 1.91 MB 0.0384 M allocs: 1.91 MB 1
onchange/shared_messagebuffer_direct/writers_16_waiters_2 0.0447 M allocs: 2.31 MB 0.0447 M allocs: 2.31 MB 1
onchange/shared_messagebuffer_direct/writers_1_waiters_1 2.66 k allocs: 0.142 MB 2.66 k allocs: 0.142 MB 1
onchange/shared_messagebuffer_direct/writers_1_waiters_8 2.67 k allocs: 0.145 MB 2.67 k allocs: 0.145 MB 1
onchange/shared_messagebuffer_direct/writers_2_waiters_16 5.33 k allocs: 0.283 MB 5.33 k allocs: 0.283 MB 1
onchange/shared_messagebuffer_direct/writers_4_waiters_4 10.6 k allocs: 0.569 MB 10.6 k allocs: 0.569 MB 1
onchange/shared_messagebuffer_direct/writers_8_waiters_1 21.2 k allocs: 1.13 MB 21.2 k allocs: 1.13 MB 1
onchange/shared_register/writers_16_waiters_2 0.0713 M allocs: 3.27 MB 0.0713 M allocs: 3.27 MB 1
onchange/shared_register/writers_1_waiters_1 3.85 k allocs: 0.189 MB 3.85 k allocs: 0.189 MB 1
onchange/shared_register/writers_1_waiters_8 5.46 k allocs: 0.264 MB 5.46 k allocs: 0.264 MB 1
onchange/shared_register/writers_2_waiters_16 14.6 k allocs: 0.839 MB 14.6 k allocs: 0.839 MB 1
onchange/shared_register/writers_4_waiters_4 18.1 k allocs: 0.878 MB 18.1 k allocs: 0.878 MB 1
onchange/shared_register/writers_8_waiters_1 0.0317 M allocs: 1.55 MB 0.0317 M allocs: 1.55 MB 1
onchange/shared_regref/writers_1_waiters_1 3.85 k allocs: 0.189 MB 3.85 k allocs: 0.189 MB 1
onchange/shared_regref/writers_1_waiters_8 5.46 k allocs: 0.264 MB 5.46 k allocs: 0.264 MB 1
onchange/shared_regref/writers_4_waiters_4 18.1 k allocs: 0.878 MB 18.1 k allocs: 0.878 MB 1
onchange/shared_regref/writers_8_waiters_1 0.0317 M allocs: 1.55 MB 0.0317 M allocs: 1.55 MB 1
quantumstates/observable/quantumoptics 22 allocs: 2.44 kB 22 allocs: 2.44 kB 1
querywait/messagebuffer_channel/writers_1_waiters_1 5.22 k allocs: 0.262 MB 5.22 k allocs: 0.262 MB 1
querywait/messagebuffer_channel/writers_1_waiters_8 14.1 k allocs: 0.753 MB 14.3 k allocs: 0.762 MB 0.989
querywait/messagebuffer_channel/writers_4_waiters_4 0.0438 M allocs: 2.24 MB 0.0433 M allocs: 2.21 MB 1.01
querywait/messagebuffer_channel/writers_8_waiters_1 0.0438 M allocs: 2.11 MB 0.0438 M allocs: 2.11 MB 1
querywait/messagebuffer_direct/writers_1_waiters_1 3.2 k allocs: 0.164 MB 3.2 k allocs: 0.164 MB 1
querywait/messagebuffer_direct/writers_1_waiters_8 12.1 k allocs: 0.657 MB 11.9 k allocs: 0.649 MB 1.01
querywait/messagebuffer_direct/writers_4_waiters_4 0.0349 M allocs: 1.84 MB 0.0344 M allocs: 1.82 MB 1.01
querywait/messagebuffer_direct/writers_8_waiters_1 25.7 k allocs: 1.31 MB 25.7 k allocs: 1.31 MB 1
querywait/register_query_wait/writers_1_waiters_1 2.59 k allocs: 0.14 MB 2.59 k allocs: 0.14 MB 1
querywait/register_query_wait/writers_1_waiters_8 11.7 k allocs: 0.594 MB 11.7 k allocs: 0.594 MB 1
querywait/register_query_wait/writers_4_waiters_4 27.1 k allocs: 1.4 MB 27.1 k allocs: 1.4 MB 1
querywait/register_query_wait/writers_8_waiters_1 20.6 k allocs: 1.12 MB 20.6 k allocs: 1.12 MB 1
querywait/register_querydelete_wait/writers_1_waiters_1 2.52 k allocs: 0.135 MB 2.52 k allocs: 0.135 MB 1
querywait/register_querydelete_wait/writers_1_waiters_8 11.7 k allocs: 0.589 MB 11.7 k allocs: 0.589 MB 1
querywait/register_querydelete_wait/writers_4_waiters_4 26.9 k allocs: 1.38 MB 26.9 k allocs: 1.38 MB 1
querywait/register_querydelete_wait/writers_8_waiters_1 20.1 k allocs: 1.08 MB 20.1 k allocs: 1.08 MB 1
register/creation_and_initialization/from_tests 2.58 k allocs: 0.943 MB 2.58 k allocs: 0.943 MB 1
tagquery/messagebuffer/query 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
tagquery/messagebuffer/query_high_arity 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
tagquery/messagebuffer/query_high_arity_predicate 0.393 k allocs: 6.22 kB 0.393 k allocs: 6.22 kB 1
tagquery/messagebuffer/query_miss 0 allocs: 0 B 0 allocs: 0 B
tagquery/messagebuffer/query_tag_dispatch 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
tagquery/messagebuffer/querydelete 3 allocs: 0.0938 kB 3 allocs: 0.0938 kB 1
tagquery/messagebuffer/querydelete_back 1 allocs: 32 B 1 allocs: 32 B 1
tagquery/messagebuffer/querydelete_front 1 allocs: 32 B 1 allocs: 32 B 1
tagquery/messagebuffer/querydelete_miss 0 allocs: 0 B 0 allocs: 0 B
tagquery/misc/from_tests 0.187 k allocs: 13.1 kB 0.187 k allocs: 13.1 kB 1
tagquery/register/query 4.99 M allocs: 0.622 GB 4.99 M allocs: 0.622 GB 1
tagquery/register/query_assigned 3 allocs: 0.281 kB 3 allocs: 0.281 kB 1
tagquery/register/query_exact_fifo 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register/query_exact_filo 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register/query_locked 3 allocs: 0.281 kB 3 allocs: 0.281 kB 1
tagquery/register/query_miss 1 allocs: 0.109 kB 1 allocs: 0.109 kB 1
tagquery/register/query_predicate 14 allocs: 0.578 kB 14 allocs: 0.578 kB 1
tagquery/register/query_tag_dispatch 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register/query_unassigned 3 allocs: 0.281 kB 3 allocs: 0.281 kB 1
tagquery/register/queryall 5.04 M allocs: 0.982 GB 5.28 M allocs: 1.03 GB 0.954
tagquery/register/queryall_fifo 6 allocs: 6.8 kB 6 allocs: 6.8 kB 1
tagquery/register/queryall_filo 6 allocs: 6.8 kB 6 allocs: 6.8 kB 1
tagquery/register/queryall_tag_dispatch 3 allocs: 0.625 kB 3 allocs: 0.625 kB 1
tagquery/register_high_arity/query_exact 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register_high_arity/query_predicate 21 allocs: 0.75 kB 21 allocs: 0.75 kB 1
tagquery/register_high_arity/queryall 3 allocs: 0.625 kB 3 allocs: 0.625 kB 1
tagquery/register_mutating/querydelete_register 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register_mutating/querydelete_regref_fifo 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register_mutating/querydelete_regref_filo 2 allocs: 0.266 kB 2 allocs: 0.266 kB 1
tagquery/register_mutating/untag_by_id 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
tagquery/register_ref/query_fifo 3 allocs: 0.375 kB 3 allocs: 0.375 kB 1
tagquery/register_ref/query_filo 3 allocs: 0.375 kB 3 allocs: 0.375 kB 1
tagquery/register_ref/query_tag_dispatch 3 allocs: 0.375 kB 3 allocs: 0.375 kB 1
tagquery/register_ref/queryall_fifo 4 allocs: 0.734 kB 4 allocs: 0.734 kB 1
tagquery/register_ref/queryall_filo 4 allocs: 0.734 kB 4 allocs: 0.734 kB 1
time_to_load 0.143 k allocs: 10.6 kB 0.148 k allocs: 10.8 kB 0.978

@nenadilic84
Copy link
Copy Markdown
Author

LLM disclosure per Stefan's request on #334: I used Claude (Anthropic) via the Claude Code CLI on this PR. Claude helped with the initial Makie recipe code, but the observable/lift patterns needed manual rework to match the existing plotting conventions in the repo. I read through all the code, ran test_plotting_2_tags_observables.jl locally, and verified the visual output. See #334 for the full breakdown.

@hanakl
Copy link
Copy Markdown
Contributor

hanakl commented Mar 1, 2026

Thanks for your work, @nenadilic84! I’ve taken an initial look and run the code, and it looks promising. I will be doing a more thorough review over the next few days.

In the meantime, can you please a. merge the latest changes from master into your branch and b. share some visuals along with brief explanations of what they demonstrate?

@Krastanov
Copy link
Copy Markdown
Member

@nenadilic84 , marking this as a draft for now, to keep my review queue a bit more organized. Do not hesitate to mark it back to ready for review if you decide to revive it.

@Krastanov Krastanov marked this pull request as draft March 20, 2026 14:37
@Krastanov
Copy link
Copy Markdown
Member

Closing this due to inactivity -- if you decide to take it back up, please do not hesitate to reopen it. Thanks for looking into it!

@Krastanov Krastanov closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants