Implement electron-nuclear spin register for MBQC distillation protocol#285
Implement electron-nuclear spin register for MBQC distillation protocol#285
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 57 57
Lines 2357 2357
=======================================
Hits 1635 1635
Misses 722 722 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
Architecture: x86_64
|
|
Comments from Stefan:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Krastanov
left a comment
There was a problem hiding this comment.
Some small requests for more inline docs
Could you post the log output of full_purification_example.jl before you merge, just so we see what it looks like
|
Output: |
There was a problem hiding this comment.
a few minor changes:
- tests merge conflict
- make a plotting example that just imports full_purification_example and makes two plots -- of success probability vs input F and of output F vs input F
- the example should take just a minute
- both examples should be tested, even if they are repetitive
- do not export the content of the MBQC module, export only the module name itself
Krastanov
left a comment
There was a problem hiding this comment.
some test failures, but otherwise it looks good
#at the top of runtests.jl do
ENV["QS_TESTRUN"] = "true"
# in example file do
samples = get(ENV, "QS_TESTRUN")=="true" ? many : few
|
I traced the current JET failure. The ResumableFunctions stack frames point at the generated msg_data = querydelete!(mb, PurifierBellMeasurementResults, ❓, ❓, ❓)
local_measurements_XX = local_tag.tag[3]
local_measurements_ZZ = local_tag.tag[4]
_, (_, remote_node, remote_measurements_XX, remote_measurements_ZZ) = msg_dataThe JET report is Suggested fix: make the delete query match the checked message and avoid destructuring the msg_data = querydelete!(mb, PurifierBellMeasurementResults, remote_chief_idx, ❓, ❓)
isnothing(msg_data) && continue # or @assert !isnothing(msg_data)
remote_measurements_XX = msg_data.tag[3]
remote_measurements_ZZ = msg_data.tag[4]That should remove the |
For issue #204