Allow single-mode homodyne and generaldyne measurements#106
Merged
Krastanov merged 5 commits intoQuantumSavory:mainfrom Mar 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage ? 97.24%
=======================================
Files ? 20
Lines ? 2686
Branches ? 0
=======================================
Hits ? 2612
Misses ? 74
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Krastanov
approved these changes
Mar 19, 2026
Member
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
huh... this was surprisingly easy. I guess the check was just too unnecessarily harsh, while the code already supports it.
apkille
approved these changes
Mar 19, 2026
Member
apkille
left a comment
apkille
left a comment
There was a problem hiding this comment.
@Krastanov we could probably do the same for generaldyne and soon to be heterodyne (#96).
Member
|
good point, I will make an issue about it to keep track of it |
5 tasks
Krastanov-agent
changed the title
Member
|
Ok, generaldyne is treated the same way now, and some barebones tests are added. I will merge and release and then proceed with the related PR in QuantumSavory.jl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
homodyne,generaldyne, and their correspondingrand(...)interfaces to measure all modes of a Gaussian state, including the 1-mode casehomodyneandgeneraldyneedge casesptrace(all_modes)throwing and assert that behavior explicitly in testsVerification
julia -tauto --project=/workdir/dev/QuantumSavory/Gabs.jl -e 'using Pkg; Pkg.test()'Companion QuantumSavory change