Skip to content

Gulp imports#4572

Open
mikepsinn wants to merge 19 commits intodevelopfrom
feature/gulp-imports
Open

Gulp imports#4572
mikepsinn wants to merge 19 commits intodevelopfrom
feature/gulp-imports

Conversation

@mikepsinn
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread ts/cypress-runner.js
}) : function(o, v) {
o["default"] = v;
});
var __importStar = (this && this.__importStar) || function (mod) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W040: If a strict mode function is executed using function invocation, its 'this' value will be undefined.
(at-me in a reply with help or ignore)

Comment thread ts/cypress-runner.js
@@ -0,0 +1,50 @@
"use strict";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W097: Use the function form of "use strict".
(at-me in a reply with help or ignore)

Comment thread ts/cypress-runner.js
else {
console.log("runLastFailedCypressTest and then run runCypressTests");
qmTests.runLastFailedCypressTest(function (err) {
console.log("Done with runLastFailedCypressTest. Going to run all now...");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W117: 'console' is not defined.
(at-me in a reply with help or ignore)

Comment thread ts/cypress-runner.js
__setModuleDefault(result, mod);
return result;
};
Object.defineProperty(exports, "__esModule", { value: true });
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W117: 'exports' is not defined.
(at-me in a reply with help or ignore)

Comment thread ts/cypress-runner.js
if (!process.env.ELECTRON_ENABLE_LOGGING) {
console.log("set env ELECTRON_ENABLE_LOGGING=\"1\" if you want to log to CI. Disabled by default to avoid leaking secrets on Travis");
}
var specName = process.env.SPEC_NAME;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W117: 'process' is not defined.
(at-me in a reply with help or ignore)

Comment thread ts/cypress-runner.js
};
Object.defineProperty(exports, "__esModule", { value: true });
var qmTests = __importStar(require("./cypress-functions"));
var env_helper_1 = require("./env-helper");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W117: 'require' is not defined.
(at-me in a reply with help or ignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant