test: broad unit/coverage suite and supporting infrastructure#282
Open
melihsunbul wants to merge 11 commits into
Open
test: broad unit/coverage suite and supporting infrastructure#282melihsunbul wants to merge 11 commits into
melihsunbul wants to merge 11 commits into
Conversation
…gments & portal tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The broad unit/integration test suite for the whole branch, plus shared test infrastructure and the residual cross-cutting changes (settings, posts, feedback queues, analytics, chat, client-query plumbing, root routes).
Concepts
main.How it works
vitest.config.tsdefaultsmaxWorkersto 50% (overridable viaVITEST_MAX_WORKERS) to stabilise the import-heavy, mock-based suite;packages/widgetvitest setup plus v8 coverage; an e2egetOtpCodehelper for email-OTP sign-in.settingsservice/types/widget config;posts(announce/merge/service/user-actions);feedbackqueues;analytics-queue;chat.notify;user.identify;merge-suggestions;admin-sidebar/settings-navwiring;__root/adminroute shells;api/{chat/stream,import,storage,upload,settings/features}; and client query plumbing (ensure-data,queries/{admin,settings,signals},mutations/index).rich-text-editor: allow data attributes and skip the second DOMPurify pass under Happy DOM (which strips allowed heading tags in that test DOM); production browsers and server-sanitised TipTap JSON are unaffected.How to use
Verification
bun run typecheck,bun run lint.📚 This is a stacked series — please review & merge in order
These 10 PRs are split by concern and ordered by dependency. Each is opened against
main, so until the PRs before it have merged, a PR's diff is cumulative (it also contains the earlier batches). As the earlier PRs merge and we rebase the next branch ontomain, each diff reduces to just its own batch. Merging all 10 in order reproduces our integrated branch exactly (verified: the cumulative tip of the series is byte-identical to it).Order (by branch):
01-data-model-foundation— data model, TypeIDs, migrations02-rbac-authz-teams— RBAC, teams, organisation & auth surfaces03-events-audit-webhooks— event dispatch, audit log, webhooks, notifications04-ticketing-crm-core— ticketing / CRM core05-sla-inboxes-routing— SLA policies, inboxes, business hours, routing06-github-sync-and-ticket-email— GitHub ticket sync, ticket email, integration platform07-widget-profiles— scoped widget profiles + ticket submission08-api-openapi-mcp— OpenAPI surface, MCP tools, conversation actions, API keys09-content-visibility— changelog/help-centre visibility, segments, portal tabs10-test-coverage— broad unit/integration test suite + supporting infraPart of the roadmap: #283