Open
Conversation
fatelei
changed the title
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fatelei
changed the title
messense
reviewed
Mar 24, 2024
messense
reviewed
Mar 24, 2024
fatelei
force-pushed
the
issue-1975
branch
2 times, most recently
from
a6eb99a to
4dc3ce8
Compare
messense
reviewed
Apr 3, 2024
messense
reviewed
Apr 3, 2024
fatelei
changed the title
fatelei
force-pushed
the
issue-1975
branch
4 times, most recently
from
58a5e61 to
d5af13c
Compare
messense
reviewed
Apr 10, 2024
messense
reviewed
Apr 10, 2024
messense
reviewed
Apr 10, 2024
|
|
||
| if !self.allow_prereleases { | ||
| interpreter.retain(|interp| { | ||
| let version = Version::new([interp.config.major as u64, interp.config.minor as u64]); |
Member
There was a problem hiding this comment.
This won't be enough, I think it also need patch version.
Member
There was a problem hiding this comment.
Python 3.13.0a6 (main, Apr 10 2024, 01:20:43) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.version_info
sys.version_info(major=3, minor=13, micro=0, releaselevel='alpha', serial=6)
>>> sys.version
'3.13.0a6 (main, Apr 10 2024, 01:20:43) [GCC 12.2.0]'
Author
There was a problem hiding this comment.
interp config only has major and minor, missing micro，we should pass minor to it?
Member
There was a problem hiding this comment.
You can modify interp config to add more detailed version info.
Member
There was a problem hiding this comment.
Perhaps we can remove major and minor, add version: pep440_rs::Version instead to interpreter config and maybe other places. I might give it a try on the weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.