Add Census SPM work expense formulas#7960
Draft
MaxGhenis wants to merge 4 commits intoPolicyEngine:mainfrom
Draft
Add Census SPM work expense formulas#7960MaxGhenis wants to merge 4 commits intoPolicyEngine:mainfrom
MaxGhenis wants to merge 4 commits intoPolicyEngine:mainfrom
Conversation
Contributor
Author
|
Alignment check against the official 2025 ASEC public-use file for 2024 looks strong after the latest childcare-cap fixes. Direct raw-CPS reconstruction now gives:
So the formula now appears directionally and aggregately aligned to Census. The remaining gap is a narrow unit-level tail, not a broad bias. Current tail read:
I filed the follow-up here to track that tail separately: #7961. My read is that this PR is ship-ready, with the remaining work clearly scoped as a follow-up alignment issue rather than a blocker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weeks_worked,spm_unit_work_expenses, andspm_unit_head_spouse_earned_capspm_unit_capped_work_childcare_expensesfrom the model formula instead of uprating the input directlyValidation
PYTHONPATH=. python3 -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/household/income/person/weeks_worked.yaml policyengine_us/tests/policy/baseline/household/expense/childcare/spm_unit_work_expenses.yaml policyengine_us/tests/policy/baseline/household/expense/childcare/spm_unit_capped_work_childcare_expenses.yaml -c policyengine_usPYTHONPATH=. pytest -q policyengine_us/tests/policy/baseline/parameters/test_uprating_extensions.pygit diff --checkNotes
work_expenses + min(childcare_expenses, max(lower_earner_cap - work_expenses, 0)), notmin(work_expenses + childcare_expenses, lower_earner_cap).