feat: add Spanish (LATAM) language support + translations from champions#1544
Open
itsjavi wants to merge 6 commits into
Open
feat: add Spanish (LATAM) language support + translations from champions#1544itsjavi wants to merge 6 commits into
itsjavi wants to merge 6 commits into
Conversation
source: pokemon champions dumps from projectpokemon and pokepc/dataset project
…lowing Gen 9 changes source: pokemon champions dumps from projectpokemon and pokepc/dataset project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Legends Z-A onwards, the main-series games will have
ES-LA(LATAM Spanish) as another official localization, apart from the upcomingPT-BR(Brazilian Portuguese) in Winds and Waves (or maybe earlier in Champions).With this, in mind and since I am also maintaining the translations in pokepc/dataset, I thought it would be a good addition that you could also benefit from the work I've done there. The data in there is transformed from the original https://github.com/projectpokemon/champout
Change description
This PR adds a new set of scripts to create a new language entry by copying another. Since most of the content in
ES-LAis practically the same asES-LA, I initially made a copy of all the translations to the new language.After that, I took the data of the Pokemon Champions dump used in
pokepc/datasetto localize both Spanish languages properly, based on the namings used in Champions.To see more about this process you can check the commits, which have a clean split of every chunk of work done.
Some missing spanish ES-ES translations were also added in the way. I am attaching the python script I used to import from pokepc JSON files to the pokeapi CSVs.
It can be reused to address other missing translations as well, or even use it as a base for adding the prose for Champions.
Rationale about the language codes:
14,es,mx,es-419,1,14I haven't used
ES-LAbecause it's not in any ISO standard. The official standard for latin-american spanish is es-419 (ugly I know). Also, since the 3rd column only supports 2 chars, I usedmxwhich is usually the one used as a base for localizing games in latin american spanish.I also changed the Brazilian Portuguese "official" flag from 0 to 1.
AI coding assistance disclosure
It helped creating the scripts for adding a new language and importing the JSONs.
Contributor check list
update_pokepc_names.py