Skip to content

chore: improve pokeapi maintenance path#1543

Open
lphuc2250gma wants to merge 1 commit into
PokeAPI:masterfrom
lphuc2250gma:maint/20260605131506
Open

chore: improve pokeapi maintenance path#1543
lphuc2250gma wants to merge 1 commit into
PokeAPI:masterfrom
lphuc2250gma:maint/20260605131506

Conversation

@lphuc2250gma
Copy link
Copy Markdown

Summary:

  • Add or tighten focused edge-case tests or type assertions in pokemon_v2/test_models.py, manage.py related to Python typing, tests, CLI ergonomics, observability; avoid docs-only changes and broad refactors.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@Naramsim
Copy link
Copy Markdown
Member

Naramsim commented Jun 6, 2026

The test aren't passing. I don't get the point of this PR.

@jemarq04
Copy link
Copy Markdown
Member

jemarq04 commented Jun 6, 2026

This reads to me like they pasted their prompt to some AI for these changes… I don’t think this PR achieved what it describes either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants