Added an option to set the initial ticks or not#3
Open
RobotZwrrl wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
Added an option to set the initial ticks or not#3RobotZwrrl wants to merge 1 commit intoPaulStoffregen:masterfrom
RobotZwrrl wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
…vos to not jump on the initial attach method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the servos jump to a position when calling attach. This is problematic for applications where servos are used in robots, with heavier and long lever arms on the servos. The solution is to include a boolean to determine if we want to set the initial ticks or not. True by default, as this was the original functionality.
Now, by calling attach(pin, false), the servo will not jump to an initial position. It can still be set to a position afterwards successfully.
Tested on Bowie robot, using a Teensy 3.2.