Spike: Auto-disable delayed retries when not explicitly set when transport lacks delayed delivery support#7690
Conversation
…support Only auto-disable when using the default config. If the user explicitly configured delayed retries, throw to signal the misconfiguration.
ramonsmits
force-pushed
the
spike/disable-delayed-retries-when-no-delayed-delivery
branch
from
c74ba75 to
62461ef
Compare
ramonsmits
changed the title
|
This seems like a nice improvements |
|
@danielmarbach what would be needed to merge this? IMHO its in a mergeable state |
Both the branch name and the PR title indicate this is a spike. Spikes should never be merged. |
The PR would be renamed @bording but after spiking and this confirmed to work and it having a test I think this is mergeable. Besides the PR title, I don't think any gaps are there besides a docs update. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3 participants
Instead of throwing at startup, log an info message and set delayed retries to 0 unless delayed retries is explicitly configured.