fix: make mihomo runtime artifacts binding-first#8
Merged
Conversation
Signed-off-by: luoshui <luoshuijs@outlook.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 29.77% 32.44% +2.66%
==========================================
Files 28 28
Lines 3140 3292 +152
==========================================
+ Hits 935 1068 +133
Misses 2060 2060
- Partials 145 164 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MySQL 8.0 rejects SIGNAL inside PREPARE/EXECUTE with ER_UNSUPPORTED_PS (1295), so the binding-first migration prechecks always crashed with 'This command is not supported in the prepared statement protocol yet' instead of surfacing the descriptive '45000' error. The integration suite caught this for migration 000007 because those tests assert on the precheck message. Move every precheck into a temporary stored procedure (CREATE PROCEDURE ... CALL ... DROP) where SIGNAL is fully supported, keeping the same SQLSTATE and human-readable messages. The static SQL guard regexes are updated for the new (single-quoted) SIGNAL form. Signed-off-by: luoshui <luoshuijs@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
go test ./...go test -tags=integration ./integration/...git diff -- go.mod go.sumproduced no output