rename sign function in slogdet kernel#78640
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Apr 21, 2026
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
co63oc
changed the title
Contributor
Author
|
/re-run all-failed |
co63oc
changed the title
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
co63oc
changed the title
Contributor
HydrogenSulfate
left a comment
HydrogenSulfate
left a comment
There was a problem hiding this comment.
对于这种文件内部使用+避免冲突的情况，是不是改成_sign会更好
Contributor
Author
|
@HydrogenSulfate 已修改CI完成 |
co63oc
changed the title
HydrogenSulfate
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
sign 重命名，避免和 c++中函数冲突
是否引起精度变化
否