[Cpp API Compatibility] Remove deepep legacy APIs by youge325 · Pull Request #78549 · PaddlePaddle/Paddle

youge325 · 2026-04-01T11:11:07Z

PR Category

Execute Infrastructure

PR Types

Deprecations

Description

拆分自 #78484

是否引起精度变化

否

paddle-bot · 2026-04-01T11:11:14Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copilot

Pull request overview

This PR continues the C++ API compatibility cleanup by removing DeepEP-specific legacy stream/event APIs from the compat headers, aiming to converge on a PyTorch-shaped surface.

Changes:

Tighten CUDA stream pool initialization by adding error checking and align getStreamFromPool overload shape to support an int priority entry point.
Remove deprecated legacy APIs that exposed raw CUDA streams (CUDAStream::raw_stream(), Event::record(cudaStream_t), and Tensor::record_stream(cudaStream_t / at::cuda::CUDAStream)).
Expose c10::Stream into namespace at to support at::Stream usage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
paddle/phi/api/include/compat/c10/cuda/CUDAStream.h	Adds `C10_CUDA_CHECK` for priority range init; adds priority-based `getStreamFromPool` overload and maps bool overload to it.
paddle/phi/api/include/compat/c10/core/Stream.h	Introduces `at::Stream` aliasing/export of `c10::Stream`.
paddle/phi/api/include/compat/c10/core/Event.h	Removes legacy `record(cudaStream_t)` overload.
paddle/phi/api/include/compat/ATen/ops/record_stream.h	Removes legacy `record_stream` overloads taking `at::cuda::CUDAStream` and `cudaStream_t`.
paddle/phi/api/include/compat/ATen/core/TensorBody.h	Removes corresponding legacy `record_stream` declarations from `Tensor`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T11:17:23Z

+
+namespace at {
+using c10::Stream;
+}


Adding namespace at { using c10::Stream; } here conflicts with an existing at::Stream definition in paddle/phi/api/include/compat/ATen/core/TensorBody.h (currently using Stream = c10::Stream;). Since TensorBody.h includes <c10/core/Stream.h>, this will trigger a redefinition error when compiling any TU that includes ATen/core/TensorBody.h.

To fix: keep a single canonical at::Stream definition (either remove the Stream alias from TensorBody.h, or drop this new at::Stream export and rely on the existing one).

Suggested change

namespace at {

using c10::Stream;

}

youge325 · 2026-04-01T11:34:17Z

/re-run all-failed

youge325 · 2026-04-01T13:14:57Z

/re-run all-failed

youge325 · 2026-04-03T05:30:28Z

/re-run all-failed

codecov-commenter · 2026-04-03T07:31:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@4919688). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #78549   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         6           
  Branches           ?         0           
===========================================
  Hits               ?         6           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SigureMo · 2026-04-10T02:29:06Z

merge 了下 develop 确认下 #78389 合入后能够监控 PR 的改动，此次 CI 应当挂掉

待 PaddlePaddle/PaddleFleet#712 合入后 rerun，CI 应当再次通过

SigureMo · 2026-04-10T02:35:56Z

喔喔，#78595 引入了新的 DeepEP 兼容性 API，稍后 #78595 合入后这边也得单独处理下

youge325 · 2026-04-10T02:38:20Z

喔喔，#78595 引入了新的 DeepEP 兼容性 API，稍后 #78595 合入后这边也得单独处理下

好的

SigureMo · 2026-04-10T03:23:00Z

稍等，先不要解决冲突，等一下 https://github.com/PaddlePaddle/Paddle/actions/runs/24223286023/job/70722751293?pr=78549 结果

SigureMo · 2026-04-10T03:28:13Z

好啦，按照预期挂啦，可以解冲突啦

youge325 · 2026-04-10T04:25:43Z

/re-run all-failed

SigureMo · 2026-04-10T05:03:46Z

https://github.com/PaddlePaddle/Paddle/actions/runs/24225463645/job/70726471802?pr=78631

ATen_resize_test 是不是 develop 直接挂了？另一个 PR 也有这个问题，develop 挂了需要尽快修一下，建议单独 PR 处理快速合入，不行就只能把单测禁了

youge325 · 2026-04-10T05:22:30Z

https://github.com/PaddlePaddle/Paddle/actions/runs/24225463645/job/70726471802?pr=78631

ATen_resize_test 是不是 develop 直接挂了？另一个 PR 也有这个问题，develop 挂了需要尽快修一下，建议单独 PR 处理快速合入，不行就只能把单测禁了

确实挂了，我看看能不能先合一个在 Mac-CPU 跳过测试的 pr

youge325 · 2026-04-10T06:39:18Z

/re-run all-failed

youge325 · 2026-04-12T02:23:42Z

上次我给 PaddleFleet checkout DeepGEMM 了，等 PFCCLab/DeepEP#11 合入后再 checkout DeepEP 吧

youge325 · 2026-04-12T08:05:19Z

/re-run all-failed

youge325 · 2026-04-27T06:05:44Z

/re-run all-failed

…de and may cause confusion

This reverts commit 0a92651.

youge325 · 2026-04-30T05:53:11Z

/re-run all-failed

youge325 · 2026-04-30T09:21:08Z

/re-run all-failed

youge325 · 2026-04-30T11:20:55Z

/re-run all-failed

youge325 · 2026-04-30T12:21:54Z

/re-run all-failed

SigureMo · 2026-05-01T10:00:08Z

这个确认不会影响 Hybrid EP 编译了么？另外目前 DeepEP 编译是否会依赖这里的相关符号？ABI 是否有不兼容情况？

youge325 · 2026-05-01T10:27:14Z

这个确认不会影响 Hybrid EP 编译了么？另外目前 DeepEP 编译是否会依赖这里的相关符号？ABI 是否有不兼容情况？

hybrid-ep编译还没本地验证过，deep-ep之前编译没问题，我再编译验证下，ABI兼容检查 0a92651 这里过了

SigureMo · 2026-05-01T12:56:17Z

hybrid-ep编译还没本地验证过，deep-ep之前编译没问题，我再编译验证下

嗯嗯，Hybrid EP 验证没问题就可以合了，节前 Hybrid EP 合入后因为 Paddle CI 有问题暂时 revert 了，#78846 修复了，节后会再合入一次

youge325 · 2026-05-01T15:43:19Z

hybrid-ep验证通过了，但是deep-ep因为最新的commit精化了编译条件，回滚一个提交可以编译通过

SigureMo · 2026-05-01T16:14:26Z

但是deep-ep因为最新的commit精化了编译条件，回滚一个提交可以编译通过

奇怪，DeepEP 的改动在 Hybrid EP 也 apply 了呀，Hybrid EP 没有一样报错吗

这个应该可以通过设置 PADDLE_CUDA_ARCH_LIST=9.0,10.0,10.3 解决

SigureMo

LGTMeow

youge325 · 2026-05-01T16:19:05Z

这个应该可以通过设置 PADDLE_CUDA_ARCH_LIST=9.0,10.0,10.3 解决

应该是可以的，本地hybrid-ep编译用的是写好的build.sh脚本，里面配置好了PADDLE_CUDA_ARCH_LIST，deep-ep因为没检测到PADDLE_CUDA_ARCH_LIST环境变量就自动推断了

Copilot AI review requested due to automatic review settings April 1, 2026 11:11

paddle-bot Bot added the contributor External developers label Apr 1, 2026

Copilot started reviewing on behalf of youge325 April 1, 2026 11:11 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

SigureMo mentioned this pull request Apr 3, 2026

[Cpp API Compatibility] Align some compat APIs #78484

Closed

youge325 force-pushed the remove-deepep-legacy-apis branch from dc7610a to f71e518 Compare April 3, 2026 03:37

youge325 force-pushed the remove-deepep-legacy-apis branch from f71e518 to 4f6abb2 Compare April 8, 2026 00:51

youge325 changed the title ~~[Cpp API Compatibility] Remove deepep legacy apis~~ [Cpp API Compatibility] Remove deepep legacy APIs Apr 8, 2026

youge325 force-pushed the remove-deepep-legacy-apis branch from 24247eb to 87acb07 Compare April 12, 2026 07:35

SigureMo mentioned this pull request Apr 12, 2026

Update submodule DeepEP PaddlePaddle/PaddleFleet#762

Merged

youge325 marked this pull request as draft April 12, 2026 11:29

youge325 force-pushed the remove-deepep-legacy-apis branch from 87acb07 to c4e8072 Compare April 26, 2026 15:51

[Cpp API Compatibility] remove CUDAStream::raw_stream()

42ca956

youge325 added 7 commits April 28, 2026 18:53

remove some other APIs

c8cb9a8

using alias for c10::Stream

1b84913

remove unused raw_stream() tests

0ebfc7e

remove inline function make_cuda_stream, which is not used in user co…

866613c

…de and may cause confusion

delete raw_stream tests

df3d776

fix dcu-build

32f783f

Add ABI symbol compatibility check

0a92651

youge325 force-pushed the remove-deepep-legacy-apis branch from c4e8072 to 0a92651 Compare April 28, 2026 10:53

Revert "Add ABI symbol compatibility check"

3ba92a9

This reverts commit 0a92651.

youge325 added 2 commits April 30, 2026 16:08

Merge branch 'develop' into remove-deepep-legacy-apis

1619e33

fix dcu build

ae1fdd3

youge325 force-pushed the remove-deepep-legacy-apis branch from 4b86d21 to ae1fdd3 Compare April 30, 2026 08:18

youge325 marked this pull request as ready for review April 30, 2026 12:22

SigureMo approved these changes May 1, 2026

View reviewed changes

SigureMo merged commit 16239ff into PaddlePaddle:develop May 1, 2026
185 of 191 checks passed

youge325 deleted the remove-deepep-legacy-apis branch May 1, 2026 16:19

Conversation

youge325 commented Apr 1, 2026 • edited by SigureMo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

是否引起精度变化

Uh oh!

paddle-bot Bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

youge325 commented Apr 1, 2026

Uh oh!

youge325 commented Apr 1, 2026

Uh oh!

youge325 commented Apr 3, 2026

Uh oh!

codecov-commenter commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SigureMo commented Apr 10, 2026

Uh oh!

SigureMo commented Apr 10, 2026

Uh oh!

youge325 commented Apr 10, 2026

Uh oh!

SigureMo commented Apr 10, 2026

Uh oh!

SigureMo commented Apr 10, 2026

Uh oh!

youge325 commented Apr 10, 2026

Uh oh!

SigureMo commented Apr 10, 2026

Uh oh!

youge325 commented Apr 10, 2026

Uh oh!

youge325 commented Apr 10, 2026

Uh oh!

youge325 commented Apr 12, 2026

Uh oh!

youge325 commented Apr 12, 2026

Uh oh!

youge325 commented Apr 27, 2026

Uh oh!

youge325 commented Apr 30, 2026

Uh oh!

youge325 commented Apr 30, 2026

Uh oh!

youge325 commented Apr 30, 2026

Uh oh!

youge325 commented Apr 30, 2026

Uh oh!

SigureMo commented May 1, 2026

Uh oh!

youge325 commented May 1, 2026

Uh oh!

SigureMo commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youge325 commented May 1, 2026

Uh oh!

SigureMo commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

youge325 commented May 1, 2026

Uh oh!

Reviewers

Assignees

youge325 commented Apr 1, 2026 •

edited by SigureMo

Loading

codecov-commenter commented Apr 3, 2026 •

edited

Loading

SigureMo commented May 1, 2026 •

edited

Loading

SigureMo commented May 1, 2026 •

edited

Loading