4th-batch-73-代码存在逻辑缺失#75790
Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom Oct 14, 2025
Merged
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #75790 +/- ##
==========================================
Coverage ? 0.00%
==========================================
Files ? 1
Lines ? 4
Branches ? 0
==========================================
Hits ? 0
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wanghuancoder
approved these changes
Oct 13, 2025
Collaborator
|
LGTM for coverage. |
sneaxiy
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
第四批-编号73(共1个)
代码在
RunKernelFunc函数中,遍历自定义算子的属性并根据字符串类型attr_type_str进行分发处理。尽管错误消息明确列出double是支持的类型,但在所有else if分支中并没有对"double"或attr_type_str == "double"的判断逻辑,因此当属性类型为double时会进入else分支并抛出Unimplemented错误。修改后增加了对
attr_type_str == "double"的分支处理,调用ctx.Attr<double>(attr_name)将其添加到kernel_ctx。'- 增加了对
std::vector<double>的支持(可选但建议),以保持与其它浮点类型的对称性。'- 更新错误提示信息中的类型列表,加入
std::vector<double>,避免误导用户。'- 此修复确保了文档/错误提示中声称支持的
double类型真正被实现。