181 catalogue tags#184
Open
SjoerdGeodienst wants to merge 10 commits intodevfrom
Open
Conversation
…vanuit url/route kunnen worden gezet.
…ar weergegeven, description max 3,5em hoog, waardoor kaartjes altijd gelijke hoogte hebben
…euwe/extra tags (als je rechts naast tags klikt verschijnt er geen/verdwijnt de cursor en is daardoor onduidelijk wat te doen)
… dashboard wissen alle tags in een keer mogelijk versie voor TST
Member
doug-leasure
left a comment
doug-leasure
left a comment
There was a problem hiding this comment.
Thanks for this, @SjoerdGeodienst . I think the functionality looks quite good. Before we are ready to deploy this to the production server, we will need to do the database work to create useful tags. I don't think we have capacity to get to that right away.
I would suggest that we wait to merge this branch until the tags are ready. Will waiting interfere with any of your other work, or is this okay for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datacatalogue is filterable on tags:
https://abeltasman.service.rug.nl/mapineq_dashboard_tst/datacatalogue
This version is connected to the test database, so only has 40 datasets of which only a view have test tags.
NB for production use, the database functions functions should be changed on production database and config set to production database.