Fix asset browser "Open" action to use OS default app again#694
Closed
Gopmyc wants to merge 1 commit intoOverload-Technologies:mainfrom
Closed
Fix asset browser "Open" action to use OS default app again#694Gopmyc wants to merge 1 commit intoOverload-Technologies:mainfrom
Gopmyc wants to merge 1 commit intoOverload-Technologies:mainfrom
Conversation
Member
|
I had something else in mind for this one. I'll tackle it myself in the next dew days. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the previous behavior of the Asset Browser "Open" contextual action.
After #686, "Open" for previewable assets (like textures/models) started going through the internal preview flow.
This change makes "Open" use the OS default application again, while keeping "Preview" unchanged for in-editor preview.
Scope is intentionally minimal:
AssetBrowser.cppRelated Issue(s)
Fixes #693
Review Guidance
Please focus on
FileContextualMenu::CreateList()inSources/OvEditor/src/OvEditor/Panels/AssetBrowser.cpp.Changed behavior:
OvTools::Utils::SystemCalls::OpenFile(filePath.string())GUIHelpers::Open(...)Expected result:
Screenshots/GIFs
N/A (behavioral fix, no UI layout change)
Checklist
I have commented my code, particularly in hard-to-understand areasI have updated the documentation accordingly