Raise minimum Ruby version to 3.2.0#442
Merged
Merged
Conversation
silug
added
the
backwards-incompatible
* Raise the minimum Ruby version to 3.3.0 in `openvox.gemspec` * Set `TargetRubyVersion` to 3.3 in `.rubocop.yml` * Fix `rubocop` warnings * Remove Ruby 3.2 and JRuby 9 from the test matrix Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Sharpie
added a commit
to Sharpie/openvox
that referenced
this pull request
Jul 6, 2026
This commit reverts the removals of `require 'set'` that were done in OpenVoxProject#442. This `require` is no longer needed with Ruby 3.2 and newer, yet JRuby 9.4 implements Ruby 3.1 so this is currently causing test failures until JRuby 10 lands in OpenVox Server. Using `require 'set'` is a no-op on newer Ruby versions. This commit can its self be reverted at a later date once the ecosystem fully supports Ruby 3.2 and newer. This partially reverts commit e83c37b.
Sharpie
added a commit
to Sharpie/openvox
that referenced
this pull request
Jul 6, 2026
This commit reverts the removals of `require 'set'` that were done in OpenVoxProject#442. This `require` is no longer needed with Ruby 3.2 and newer, yet JRuby 9.4 implements Ruby 3.1 so this is currently causing test failures until JRuby 10 lands in OpenVox Server. Using `require 'set'` is a no-op on newer Ruby versions. This commit can its self be reverted at a later date once the ecosystem fully supports Ruby 3.2 and newer. This partially reverts commit e83c37b. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
added a commit
to Sharpie/openvox
that referenced
this pull request
Jul 6, 2026
This commit reverts the removals of `require 'set'` that were done in OpenVoxProject#442. This `require` is no longer needed with Ruby 3.2 and newer, yet JRuby 9.4 implements Ruby 3.1 so this is currently causing test failures until JRuby 10 lands in OpenVox Server. Using `require 'set'` is a no-op on newer Ruby versions. This commit can its self be reverted at a later date once the ecosystem fully supports Ruby 3.2 and newer. This partially reverts commit e83c37b. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
8 tasks
silug
added a commit
to silug/openvox
that referenced
this pull request
Jul 6, 2026
Lower the minimum Ruby version to 3.2 to maintain backwards compatibility with OpenVox 8 agents. This partially reverts the changes in e83c37b (OpenVoxProject#442). Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Sharpie
changed the title
Member
|
Changed the title from the original "3.3.0" -> "3.2.0" so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
openvox.gemspecTargetRubyVersionto 3.3 in.rubocop.ymlrubocopwarningsChecklist
I have:
Signed-off-byannotation to each of my commits