Patch unit tests by updating OTIO_PLUGIN_MANIFEST_PATH env var#6
Patch unit tests by updating OTIO_PLUGIN_MANIFEST_PATH env var#6douglascomet wants to merge 1 commit intoOpenTimelineIO:mainfrom
OTIO_PLUGIN_MANIFEST_PATH env var#6Conversation
Signed-off-by: Doug Halley <douglascomet@gmail.com>
48f052d to
edf0f1f
Compare
|
@douglascomet Did the unit tests fail locally after installing the plugin in your virtual environment? |
@apetrynet, I did not think to try that! The unit-tests do in fact work and succeed if the plugin is installed into the virtual environment like that. I remember those being the steps for developing and testing with the main OTIO repo but those steps are not currently mentioned in the |
|
Glad to hear it works. How do you feel about closing this PR? |
|
@apetrynet, I don't mind closing this PR now knowing that the adapter repos should be dev-ed the same way as the main OTIO repo. I didn't know the plugin system would auto-magically find the plugins just by being in the same environment. We can also close OpenTimelineIO/otio-cmx3600-adapter#7, which I made for the Also, fwiw, the |
|
Let's see what other think before we land on closing or not. |
The unit tests modules were not functional without registering
otio_svg_adapter/plugin_manifest.jsonwith theOTIO_PLUGIN_MANIFEST_PATHenv var.