remove dead eb.encrypted_assertions_require_outer_signature feature flag#2004
Open
kayjoosten wants to merge 1 commit into
Open
remove dead eb.encrypted_assertions_require_outer_signature feature flag#2004kayjoosten wants to merge 1 commit into
kayjoosten wants to merge 1 commit into
Conversation
The flag has been inoperative since 2018: Bindings.php unconditionally rejects encrypted assertions without an outer signature regardless of the flag value. Wiring it up is not viable because the SAML2 library checks wasSignedAtConstruction() on the original EncryptedAssertion objects (before decryption), which always returns false, so the library itself would reject such responses too. Removes the flag from engineblock_features.yaml, parameters.yml.dist, TestFeatureConfiguration, and cleans up the Behat scenarios that referenced it (removing the @Skip scenario that tested the broken path). Closes #2002
Contributor
|
Don't merge before Bas has approved its removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag has been inoperative since 2018: Bindings.php unconditionally rejects encrypted assertions without an outer signature regardless of the flag value. Wiring it up is not viable because the SAML2 library checks wasSignedAtConstruction() on the original EncryptedAssertion objects (before decryption), which always returns false, so the library itself would reject such responses too.
Removes the flag from engineblock_features.yaml, parameters.yml.dist, TestFeatureConfiguration, and cleans up the Behat scenarios that referenced it (removing the @Skip scenario that tested the broken path).
Closes #2002